Linkage type fix for global variables translation #1148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a workaround to fix translation of linkage type of "llvm.used" and "llvm.compiler.used" global variables that should be "appending" instead of "export".
|
@AlexeySotkin @AlexeySachkov @mlychkov @MrSidims please take a look |
MrSidims
approved these changes
Aug 9, 2021
AlexeySotkin
approved these changes
Aug 9, 2021
svenvh
reviewed
Aug 10, 2021
| ; CHECK-LLVM: @llvm.compiler.used = appending global | ||
| @llvm.compiler.used = appending global [1 x i8*] [i8* bitcast (%union.int_double addrspace(1)** @._c0.ref to i8*)] #0 | ||
|
|
||
| attributes #0 = { "VCGlobalVariable" } |
There was a problem hiding this comment.
We can translate it to SPIR-V without any extensions if we remove this attribute. We don't need it for the purpose of this test, right?
There was a problem hiding this comment.
Yes, we need it. I tried to remove this attribute and then translate, but @llvm.compiler.used also disappeared. But I found extensions, which are needed to translate this test insted of all.
AlexeySachkov
approved these changes
Aug 12, 2021
DmitryBushev
pushed a commit
to DmitryBushev/SPIRV-LLVM-Translator
that referenced
this pull request
Aug 30, 2021
This is a workaround to fix translation of linkage type of "llvm.used" and "llvm.compiler.used" global variables that should be "appending" instead of "export".
DmitryBushev
pushed a commit
to DmitryBushev/SPIRV-LLVM-Translator
that referenced
this pull request
Aug 30, 2021
This is a workaround to fix translation of linkage type of "llvm.used" and "llvm.compiler.used" global variables that should be "appending" instead of "export".
DmitryBushev
pushed a commit
to DmitryBushev/SPIRV-LLVM-Translator
that referenced
this pull request
Aug 30, 2021
This is a workaround to fix translation of linkage type of "llvm.used" and "llvm.compiler.used" global variables that should be "appending" instead of "export".
DmitryBushev
pushed a commit
to DmitryBushev/SPIRV-LLVM-Translator
that referenced
this pull request
Aug 30, 2021
This is a workaround to fix translation of linkage type of "llvm.used" and "llvm.compiler.used" global variables that should be "appending" instead of "export".
DmitryBushev
pushed a commit
to DmitryBushev/SPIRV-LLVM-Translator
that referenced
this pull request
Aug 30, 2021
This is a workaround to fix translation of linkage type of "llvm.used" and "llvm.compiler.used" global variables that should be "appending" instead of "export".
This was referenced Aug 30, 2021
MrSidims
pushed a commit
that referenced
this pull request
Sep 3, 2021
This is a workaround to fix translation of linkage type of "llvm.used" and "llvm.compiler.used" global variables that should be "appending" instead of "export".
MrSidims
pushed a commit
that referenced
this pull request
Sep 3, 2021
This is a workaround to fix translation of linkage type of "llvm.used" and "llvm.compiler.used" global variables that should be "appending" instead of "export".
MrSidims
pushed a commit
that referenced
this pull request
Sep 3, 2021
This is a workaround to fix translation of linkage type of "llvm.used" and "llvm.compiler.used" global variables that should be "appending" instead of "export".
DmitryBushev
pushed a commit
to DmitryBushev/SPIRV-LLVM-Translator
that referenced
this pull request
Sep 3, 2021
This is a workaround to fix translation of linkage type of "llvm.used" and "llvm.compiler.used" global variables that should be "appending" instead of "export".
DmitryBushev
pushed a commit
to DmitryBushev/SPIRV-LLVM-Translator
that referenced
this pull request
Sep 3, 2021
This is a workaround to fix translation of linkage type of "llvm.used" and "llvm.compiler.used" global variables that should be "appending" instead of "export".
MrSidims
pushed a commit
that referenced
this pull request
Sep 3, 2021
This is a workaround to fix translation of linkage type of "llvm.used" and "llvm.compiler.used" global variables that should be "appending" instead of "export".
MrSidims
pushed a commit
that referenced
this pull request
Sep 6, 2021
This is a workaround to fix translation of linkage type of "llvm.used" and "llvm.compiler.used" global variables that should be "appending" instead of "export".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround to fix translation of linkage type of "llvm.used" and
"llvm.compiler.used" global variables that should be "appending" instead of
"export".