Add JointMatrixGetElementCoordINTEL instruction #1834
Conversation
The instruction returns (Row, Column) coordinate of dynamically selected element of a matrix Updated version of the spec is here intel/llvm#8175 Instruction correctness checks will be added later among non-backward compatible changes. Signed-off-by: Sidorov, Dmitry <[email protected]>
MrSidims
force-pushed
the
matrix-get-coord
branch
from
d0c9a15 to
b76e49e
Compare
| @@ -3324,9 +3324,24 @@ class SPIRVJointMatrixINTELInst : public SPIRVJointMatrixINTELInstBase { | |||
| _SPIRV_OP(JointMatrixLoad, true, 6, true) | |||
| _SPIRV_OP(JointMatrixStore, false, 5, true) | |||
| _SPIRV_OP(JointMatrixMad, true, 7) | |||
| // TODO: move to SPIRVJointMatrixINTELWorkItemInst | |||
There was a problem hiding this comment.
Why can't we move this right away in this PR? To preserve backward compatibility by not requiring support of JointMatrixWIInstructions capability for now?
There was a problem hiding this comment.
Usage of OpJointMatrixWorkItemLength will currently emit just CapabilityJointMatrixINTEL. Which is supported in our downstream. Given the fact, that it's SYCL's counterpart is already implemented and used in tests and user code making the SPIR-V instruction be bound with CapabilityJointMatrixWIInstructionsINTEL would make these tests/user code not working, since this capability is not yet introduced in our downstream.
With this patch I'm introducing it, and then, when our drivers adopt it - the TODO can be resolved.
The instruction returns (Row, Column) coordinate of dynamically selected element of a matrix
Updated version of the spec is here
intel/llvm#8175
Instruction correctness checks will be added later among non-backward compatible changes.
Signed-off-by: Sidorov, Dmitry [email protected]