Fix translation of APInt constants #752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlychkov
reviewed
Sep 23, 2020
MrSidims
force-pushed
the
private/MrSidims/APInt
branch
2 times, most recently
from
2d233c2 to
b64279c
Compare
mlychkov
approved these changes
Sep 23, 2020
Problem here is that this requires to make a lot of reworks in encode/decode functions: APInt is mapped to just SPIRVInt, hence the default flow shall be also re-worked. |
MrSidims
force-pushed
the
private/MrSidims/APInt
branch
from
b64279c to
bbffd78
Compare
AlexeySotkin
approved these changes
Oct 1, 2020
MrSidims
force-pushed
the
private/MrSidims/APInt
branch
from
bbffd78 to
0ae0698
Compare
AlexeySachkov
approved these changes
Oct 2, 2020
MrSidims
force-pushed
the
private/MrSidims/APInt
branch
from
0ae0698 to
5223ad9
Compare
Previously APInt constants were being stored into uint64_t value with following encoding/decoding. Now they are being packed into SPIRVWords array directly. Signed-off-by: Dmitry Sidorov <[email protected]>
MrSidims
force-pushed
the
private/MrSidims/APInt
branch
from
5223ad9 to
85d271a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously APInt constants were being stored into uint64_t value
with following encoding/decoding. Now they are being packed into
SPIRVWords array directly.
Signed-off-by: Dmitry Sidorov [email protected]