-
Notifications
You must be signed in to change notification settings - Fork 71
Generalized use of property list #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalized use of property list #73
Conversation
This is a great idea. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like a good proposal.
Adds optional property_list parameters to all user-constructible SYCL object constructors that did not have it before
85dc270
to
3b82101
Compare
You introduce an exception; current properties are specific; if we dont want it to be in this one, then I will have to change it; with SYCL NEXT constructing object with introp type is to use make function I still want to remove this exception. I would have to change the wording because this is a restriction they have as well. Could be a separate issue. OK to be separate issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some merge crumbles?
I wonder if we should move to a more type-based system for properties, such that passing invalid properties for one class will be caught by the type system. I expect that, if everything accepts properties, it opens the door for a lot of user error, and requires a lot of error handling.. |
In addition to #78 there are additional explicit constructors required before this change goes in, right? e.g. context? |
I have pushed another PR #81, which introduces a clarification to |
mar 19:
|
I noticed that there were some changes missing to
This has been fixed with 69b362c. |
Adds optional
property_list
parameters to all user-constructible SYCLobject constructors that did not have it before.
This is the wording related this proposal which has been discussed internally.