Skip to content

Don't overwrite unnecessary nodes #110

Closed
@nonara

Description

@nonara

Presently, the plugin resolves for every import, require, etc. call / statement, and it overwrites all of them — irrespective of there being an actual need to overwrite them.

By changing this to only process nodes which are matched by paths or explicitly tagged, we can make the process faster, more efficient, and ultimately reduce bug report volume.

While the latter point is not necessarily a positive, the former two make this a very valuable change.

The reason this has not already been done is because there was no compiler API logic for determining paths matching. However, I've identified the logic and can replicate it by a couple of simple calls to the publicly exported underlying compiler matching functionality, which makes this possible.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions