fix py36 xarray master build #200
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (seems to) fix the current bug with the python 3.6, xarray master build. It seems that the newest version of
xarray.combine_by_coords
added the optioncombine_attrs
, allowing the user to specify how to handle attributes while combining multiple datasets. The default isno_conflicts
, which in this case causes a problem with thehistory
attribute since each dataset corresponds to an iteration (or None for the grid), each of which is different and shows up in this attribute as "created by calling open_mdsdataset(.....)"It seems that the old default was to simply drop attributes, so that's what I'm setting the option to for a first pass. We could also just drop the attributes before calling
xr.combine_by_coords
, and remove the need for testing.