Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

try xenial and python 3.8 #55

Closed
wants to merge 1 commit into from
Closed

try xenial and python 3.8 #55

wants to merge 1 commit into from

Conversation

charris
Copy link
Contributor

@charris charris commented Jul 30, 2019

No description provided.

@mattip
Copy link
Contributor

mattip commented Aug 21, 2019

Does multibuild support 3.8 ? I don't understand how the new virtualenv is supposed to be activated because in both the unsucessful job here and in the successful 3.7 job it seems a 3.5 virtualenv is activated?

@matthew-brett any ideas?

@matthew-brett
Copy link
Contributor

matthew-brett commented Aug 21, 2019 via email

@mattip
Copy link
Contributor

mattip commented Aug 21, 2019

Reading through the PRs for 3.8 in manylinux it seems the merged 3.8a2, then backed it out since the ABI is not stable until release. So we can only build/test wheels after it is officially released? That seems strange.

@mattip
Copy link
Contributor

mattip commented Aug 21, 2019

Ahh, my bad. pypa/manylinux#333 has a stable ABI, but something else is preventing merging it into manylinux, something about keys

@mattip
Copy link
Contributor

mattip commented Aug 21, 2019

https://hub.docker.com/r/matthewbrett/trusty

Would you accept a PR to https://github.com/matthew-brett/trusty for any or all of the following?

  • upgrade trusty to xenial 16.04 since trusty is EOL
  • use 3.8b3
  • use python -mensurepip; python -mpip install --upgrade pip setuptools instead of get_pip.py

@matthew-brett
Copy link
Contributor

matthew-brett commented Aug 21, 2019 via email

@mattip
Copy link
Contributor

mattip commented Aug 21, 2019

a multibuild-test repo

Open the repo, and give me permissions. I'll see what I can do

@charris
Copy link
Contributor Author

charris commented Aug 21, 2019

How about bionic instead of xenial?

@mattip
Copy link
Contributor

mattip commented Aug 21, 2019

@charris what do you think of this claim: most the developers will be testing with a more modern system, it would be good to make sure we are not leaving xenial users behind.

@matthew-brett
Copy link
Contributor

matthew-brett commented Aug 21, 2019 via email

@mattip
Copy link
Contributor

mattip commented Aug 21, 2019

multibuild as well? They go together, no? Can you join the zoom meeting today, at least for part of it, to discuss this?

@matthew-brett
Copy link
Contributor

matthew-brett commented Aug 21, 2019 via email

@charris
Copy link
Contributor Author

charris commented Aug 21, 2019

it would be good to make sure we are not leaving xenial users behind.

We are talking about generating wheels on travis and mostly the testing environment, I think. The only problem I can see with bionic on travis is that python2.5 is no longer supported, on the plus side, that is another two years we can leave off fiddling with it. In any case, once we figure out how to change the distro it should be easy to do it again :)

@@ -20,7 +20,7 @@ language: python
# Default Python version is usually 2.7
python: 3.5
sudo: required
dist: trusty
dist: xenial
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will have absolutely no effect and probably should just be removed so travis uses its default. The containers used in the build and test phases are different from this one. The actual image used is controlled by the build_wheel and install_run function calls in this file, which set the docker image to use from multibuild/travis_linux_steps.sh

@charris charris closed this Aug 23, 2019
@charris charris deleted the try-python-3.8 branch August 23, 2019 21:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants