-
Notifications
You must be signed in to change notification settings - Fork 21
Conversation
Does multibuild support 3.8 ? I don't understand how the new virtualenv is supposed to be activated because in both the unsucessful job here and in the successful 3.7 job it seems a 3.5 virtualenv is activated? @matthew-brett any ideas? |
The way it works for Linux is:
* Multibuild starts any old virtualenv on the Travis-CI container - in this
case, a Python 3.5 virtualenv
* From there, it spins up a Manylinux container, activating the appropriate
Python version there, and builds the wheel
* When that returns, Multibuild spins up a test container, activating the
appropriate Python version, and tests the wheel.
For Python 3.8 support we need:
* Python 3.8 on the Manylinux container
* Python 3.8 on the test container.
I maintain the test container, which is now very old:
https://hub.docker.com/r/matthewbrett/trusty
|
Reading through the PRs for 3.8 in manylinux it seems the merged 3.8a2, then backed it out since the ABI is not stable until release. So we can only build/test wheels after it is officially released? That seems strange. |
Ahh, my bad. pypa/manylinux#333 has a stable ABI, but something else is preventing merging it into manylinux, something about keys |
Would you accept a PR to https://github.com/matthew-brett/trusty for any or all of the following?
|
Yes, absolutely - I'd love help for the test images.
Maybe we could make a Numpy dockerhub account or similar, and host there.
I don't think it would make sense to reuse the Trusty repo - maybe
something like a multibuild-test repo, and start with a Xenial container
there? I think the Dockerfiles would port OK, although the 32-bit version
might be annoying - it was for Trusty.
|
Open the repo, and give me permissions. I'll see what I can do |
How about bionic instead of xenial? |
@charris what do you think of this claim: most the developers will be testing with a more modern system, it would be good to make sure we are not leaving xenial users behind. |
What do you think about hosting the repo in the numpy organization?
|
multibuild as well? They go together, no? Can you join the zoom meeting today, at least for part of it, to discuss this? |
Yes, sure - I'll join the meeting at the beginning if I may (dogs allowing).
|
We are talking about generating wheels on travis and mostly the testing environment, I think. The only problem I can see with bionic on travis is that python2.5 is no longer supported, on the plus side, that is another two years we can leave off fiddling with it. In any case, once we figure out how to change the distro it should be easy to do it again :) |
@@ -20,7 +20,7 @@ language: python | |||
# Default Python version is usually 2.7 | |||
python: 3.5 | |||
sudo: required | |||
dist: trusty | |||
dist: xenial |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will have absolutely no effect and probably should just be removed so travis uses its default. The containers used in the build and test phases are different from this one. The actual image used is controlled by the build_wheel and install_run function calls in this file, which set the docker image to use from multibuild/travis_linux_steps.sh
No description provided.