-
Notifications
You must be signed in to change notification settings - Fork 444
Make tzinfo opt-in. #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Seems like this needs to be an opt-out to avoid breaking existing users who are now relying on the DB having the time zones loaded. I know I personally ran into this with the |
How do this look? |
LGTM. Let's see what the maintainers have to say. |
Any update? |
Update? |
LGTM |
I like the feature, but I'm not so sure about the name. 😕 I'm thinking maybe something slightly more descriptive of exactly what's being skipped, like |
Me either.
Look fine to me, I can update the PR now, if it okay? |
Yeah, sounds good enough; thanks for bearing with us. 👍
|
Done, also not sure about the commit message. Maybe it fine. |
LGTM |
Commit message seems fine. |
Not sure if it should be opt-in or opt-out, also a little unsure about the env name
MYSQL_LOAD_TIME_ZONE_TABLES
. I think it should be opt-in.#24 depends on this.