GSOC'25 - MDEV-12513 Implementation of Native INTERVAL Data Type #4108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hi @HazemRawi , thanks for the PR. Here are my first impressions, please update the PR with changes. Thanks!
mysql-test/main/type_interval.test
Outdated
| CREATE TABLE t13 (a INTERVAL HOUR(3) TO SECOND(2) ); | ||
| CREATE TABLE t14 (a INTERVAL MINUTE TO SECOND(4) ); | ||
|
|
||
| DROP TABLE t2; |
There was a problem hiding this comment.
Consolidate these to one statement, like this (but with all your new tables):
DROP TABLE t2, t3, t4;
sql/sql_yacc.yy
Outdated
| | INTERVAL_SYM interval_qualifier | ||
| { | ||
| $$.set(&type_handler_interval_DDhhmmssff); | ||
|
|
There was a problem hiding this comment.
Remove unneeded blank line.
HazemRawi
force-pushed
the
MDEV-12513
branch
2 times, most recently
from
3d32563 to
ef533ea
Compare
|
Thanks you! updated with the requested changes ; |
HazemRawi
commented
Jun 19, 2025
| @@ -15708,6 +15747,13 @@ temporal_literal: | |||
| YYCSCL, true)))) | |||
| MYSQL_YYABORT; | |||
| } | |||
| | INTERVAL_SYM %prec EMPTY_FROM_CLAUSE TEXT_STRING interval_qualifier | |||
| { | |||
| if (unlikely(!($$= type_handler_datetime.create_literal_item(thd, | |||
There was a problem hiding this comment.
Delegating interval handling to the type_handler_datetime.create_literal_item is the reason why some some tests fail -- This will be resolved in the next commit by implementing type_handler_interval.create_literal_item
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TODO: fill description here
Release Notes
TODO: What should the release notes say about this change?
Include any changed system variables, status variables or behaviour. Optionally list any https://mariadb.com/kb/ pages that need changing.
How can this PR be tested?
TODO: modify the automated test suite to verify that the PR causes MariaDB to behave as intended.
Consult the documentation on "Writing good test cases".
If the changes are not amenable to automated testing, please explain why not and carefully describe how to test manually.
Basing the PR against the correct MariaDB version
mainbranch.PR quality check