-
Notifications
You must be signed in to change notification settings - Fork 473
add a mz_license_keys catalog table #33121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fc448f6
to
f06fa09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably needs a bunch of test rewrites and maybe docs changes.
if !catalog.state.license_key.id.is_empty() { | ||
builtin_table_updates.push( | ||
catalog.state.resolve_builtin_table_update( | ||
catalog | ||
.state | ||
.pack_license_key_update(&catalog.state.license_key)?, | ||
), | ||
); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm.. does this get cleared on restart? Just trying to think the the license key update story.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'll verify this tomorrow, but i'm pretty confident that this gets reset on every restart (it's the same codepath that the egress ip table uses)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, this updates on restart.
f7e1288
to
d44d55b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am good with the docs changes.
| Field | Type | Meaning | | ||
| ----------- | ----------- | -------- | | ||
| `id` | [`text`] | The identifier of this particular license key. | | ||
| `organization` | [`text`] | The name of the organization that this license key was issued to. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for my edification ... does this organization map to something like the company name associated with the account setting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, it's just an arbitrary string identifying the organization that this license key was issued to. for now, it's just the frontegg tenant id for the customer, but it could be anything (i think for community edition license keys, it will probably be the user's email address, for instance)
| ----------- | ----------- | -------- | | ||
| `id` | [`text`] | The identifier of this particular license key. | | ||
| `organization` | [`text`] | The name of the organization that this license key was issued to. | | ||
| `environment_id` | [`text`] | The environment ID that this license key was issued for. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, just for my edification ... what does the environment_id map to? (heh heh ... I'm sure it's in some design doc somewhere)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
environment_id is the use case id which corresponds to the --environment-id
flag passed to environmentd
8e8e65f
to
8e653f4
Compare
since we want to be able to display them to the user
8e653f4
to
07ba26c
Compare
Motivation
we'll want to be able to have a page in the self-managed console which displays license key metadata so that users can see when their key is going to expire
Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way), then it is tagged with aT-proto
label.