[persist] Monoid bound for the diff type in Persist #33127
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Right now a diff sum of
None
sometimes means "zero", and sometimes means "unknown". This makes it harder to write assertions on the diffs... replacing a 0-sum batch with a 7-sum batch is clearly bad, but replacing an unknown-sum batch with a 7-sum batch might be fine.Tips for reviewer
This adds a stronger requirement for all Persist usage. This would probably not be worth it if we thought we were realistically going to use Persist with a non-monoid diff type... but that seems very unlikely, so this seems worth doing to avoid any additional risk of errors.
First commit has the search-and-replace; second commit has a small amount of code that takes advantage of the new bound.
Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way), then it is tagged with aT-proto
label.