Update changelogs correctly for monorepo packages #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
fix-monorepo-changelog-update
branch
2 times, most recently
from
8568ae1 to
b75528c
Compare
Packages within a monorepo should now have their changelogs correctly updated. Previously the update step was incorrectly expecting the monorepo package to be using a tag of the format `v[version]`. This is not how we tag packages within an indepentently versioned monorepo because we need some way to distinguish the tags used for each project. This step has been updated to specify the expected tag prefix as being the package name followed by `@`.
Gudahtt
force-pushed
the
fix-monorepo-changelog-update
branch
from
b75528c to
8f22a5e
Compare
|
This is ready for review, except that the problem and solution aren't well tested at the moment. I'm looking at adding a couple more functional tests now to cover those. |
Two tests have been added to ensure changelog updates work correctly. One test handles the first package release, and the other test handles all other packages releases after the first.
|
Alright, this should be fully ready for review now. Two additional tests have been added to cover this behavior. |
rickycodes
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages within a monorepo should now have their changelogs correctly updated. Previously the update step was incorrectly expecting the monorepo package to be using a tag of the format
v[version]. This is not how we tag packages within an indepentently versioned monorepo because we need some way to distinguish the tags used for each project.This step has been updated to specify the expected tag prefix as being the package name followed by
@.Fixes #43