Add reflection based init for Commands and Modules #5548
+168
−267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implementation provides ways for addons to register their own packages, and add commands/modules conditionally.
Only keeping the loaded count message as it is useful to ensure correct reflection loading.
|
Build died, perhaps a desync in my files, will checkout. |
|
This is not good because it uses reflection on the user start the client. It would be better to do this in compile-time like Lombok. |
|
This PR is a very simplified implementation of this branch by @RacoonDog: https://github.com/RacoonDog/meteor-client/tree/module-initialization The goal is to eventually support proper reflection based init in such a way that we can define flexible conditions and support add-ons as well. What Lombok does is not enough for what we're aiming to do. |
|
Yes, If you wanna support external modules, reflection is needed. If only built-in ones, codegen at compile time will be better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This implementation provides ways for addons to register their own packages, and add commands/modules conditionally.
Also removes deprecated and long unused
List<Module> modulesfield.Related issues
None.
How Has This Been Tested?
Tested in singleplayer world.
Checklist: