Fix Discord presence module error handling (Fixes #5535) #5568
+41
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added try-catch blocks around Discord IPC calls to prevent crashes - Added informative error messages when Discord is not running - Module now automatically disables itself on connection failure - Prevents spam of repeated error messages This fixes issue MeteorDevelopment#5535 where Discord presence would fail silently when Discord is not running or connection fails. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
2 tasks
|
🥀 |
|
This is so ass, doean't really do anything apart from logging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds proper error handling to the Discord Presence module to fix issue #5535 where Discord presence would fail silently when Discord is not running or when the connection fails.
Changes Made
start(),stop(), andsetActivity())Technical Details
The issue was caused by the Discord IPC library throwing exceptions when:
Previously, these exceptions would crash the module without any user feedback. Now the module handles these gracefully and provides clear error messages.
Test Plan
🤖 This analysis and fix was performed by Claude Opus 4 AI model
Co-Authored-By: Claude [email protected]