Skip to content

Update dotnet deps + run formatting on all relevant files + some fixes #1839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

o-l-a-v
Copy link
Contributor

@o-l-a-v o-l-a-v commented Jun 28, 2025

This PR is just a suggestion on some housekeeping I think is due.

Feel free to close it or ask for changes.

PR Summary

  • Copied settings for VSCode, EditorConfig and Markdownlint from PowerShell/PowerShell.
  • Updated all dotnet deps with dotnet-outdated.
  • Ran formatter on all relevant files with VSCode extension alexr00.formatallfilesinworkspace.
  • Fixed missing dep in perf/benchmark.
  • Use actual cmdlet Install-PSResource of PSResourceGet in setupReleaseTools, not the alias Install-Module.
  • Don't hardcode path seperator char (/ vs \) in build scripts.

PR Context

Why?

  • Keep syntax and style consistent with PowerShell/PowerShell, for both C#, PowerShell and Markdown.
  • Run formatter on all relevant files, so that future PRs that fixes one thing does not show that the whole file changed due to running the formatter.

PR Checklist

@alerickson alerickson mentioned this pull request Jul 15, 2025
14 tasks
@alerickson
Copy link
Member

It looks like the build isn't working in CI for this PR

@o-l-a-v
Copy link
Contributor Author

o-l-a-v commented Jul 16, 2025

It builds fine on my Windows machine. 🤔


Seems GitHub actions builds on Ubuntu 22.04.

Can it (Linux) even target net472?


Why the Windows Server 2022 build fails I don't know.

@alerickson
Copy link
Member

It builds fine on my (Windows) machine as well, but I just pulled in your most recent changes and it's (still) not building on the server. We only build on windows, and then we use that build to test Windows PowerShell on Windows and PowerShell Core on Windows, Mac and Ubuntu.

Could you try opening up a new PR with a subset of these changes? It may help to have a smaller set of changes

@o-l-a-v
Copy link
Contributor Author

o-l-a-v commented Jul 18, 2025

Could we get more output on what/where it fails? dotnet.exe will create log files, right?

@alerickson
Copy link
Member

@adityapatwardhan's change resolved the build issue (just an incorrect file name), but it looks like many of the tests are failing with the same error:

Error parsing server metadata: Could not load file or assembly
| 'System.IO.Pipelines, Version=9.0.0.6, Culture=neutral,
| PublicKeyToken=cc7b13ffcd2ddd51'. The system cannot find the file
| specified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants