Update ubuntu 18.04 entrypoint #399
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmenaga
approved these changes
Mar 30, 2020
RDIL
suggested changes
Mar 30, 2020
| @@ -74,3 +74,4 @@ LABEL maintainer="PowerShell Team <[email protected]>" \ | |||
| # Use PowerShell as the default shell | |||
| # Use array to avoid Docker prepending /bin/sh -c | |||
| CMD [ "pwsh-preview" ] | |||
|
|
|||
There was a problem hiding this comment.
Also unneeded extra space here
| @@ -0,0 +1,9 @@ | |||
| #!/bin/sh | |||
| set -e | |||
|
|
|||
There was a problem hiding this comment.
It doesn't look like this file is used?
There was a problem hiding this comment.
This causes the script to quit if there is an error
There was a problem hiding this comment.
Right, but I'm saying the entire shell file
ghost
added
|
Closing this as the proposal hasn't advanced and further work most likely won't happen for some time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Update ubuntu 18.04 entrypoint
PR Checklist
Dockerfile,.sh,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.