Skip to content

Split AzDO jobs + refactor into templates #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Apr 18, 2019

Conversation

rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Apr 17, 2019

  • Refactors jobs so that the Windows PowerShell job also uses the same template
  • Puts some variables into their own template files for reuse (ideally in release builds)
    • Environment variables
    • Build images (so as images change, we can update in one place)
  • Adds display names so things look pretty in PRs

@rjmholt rjmholt requested a review from TylerLeonhardt April 17, 2019 23:42
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts on the extra files

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjmholt rjmholt merged commit 0ba7868 into PowerShell:master Apr 18, 2019
@rjmholt rjmholt deleted the build-improvements branch December 11, 2019 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants