Skip to content

Change changelog script to use PSES syntax #1486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2018

Conversation

rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Aug 16, 2018

PR Summary

Changes the changelog generation script so the output doesn't need rewriting on releases.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@TylerLeonhardt
Copy link
Member

Can you post the output for reference?

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@rjmholt
Copy link
Contributor Author

rjmholt commented Aug 16, 2018

Example:

> .\tools\Get-PowerShellExtensionChangelog.ps1 -LastReleaseTag 'v1.8.2' -NewReleaseTag 'v1.8.3' -Token $myToken

## v1.8.3
### Thursday, August 16, 2018
#### [vscode-powershell](https://github.com/powershell/vscode-powershell)

- [vscode-PowerShell](https://github.com/PowerShell/vscode-PowerShell) -
  Change changelog script to use PSES syntax
- [vscode-PowerShell #1483](https://github.com/PowerShell/vscode-PowerShell/pulls/1483) -
  Update CHANGELOG for v1.8.3
- [vscode-PowerShell #1480](https://github.com/PowerShell/vscode-PowerShell/pulls/1480) -
  Use PowerShell signing script in VSTS builds
- [vscode-PowerShell #1460](https://github.com/PowerShell/vscode-PowerShell/pulls/1460) -
  Use newer version for preleases
- [vscode-PowerShell #1475](https://github.com/PowerShell/vscode-PowerShell/pulls/1475) -
  Change resourceLangId to editorLangId so right-click works properly with unsaved files  (Thanks @corbob!)
- [vscode-PowerShell #1467](https://github.com/PowerShell/vscode-PowerShell/pulls/1467) -
  (GH-1458) Remove region folding from non-region areas  (Thanks @glennsarti!)

#### [PowerShellEditorServices](https://github.com/powershell/PowerShellEditorServices)

- [PowerShellEditorServices](https://github.com/PowerShell/PowerShellEditorServices) -
  Increment version number
- [PowerShellEditorServices #723](https://github.com/PowerShell/PowerShellEditorServices/pulls/723) -
  Update CHANGELOG for v1.8.3
- [PowerShellEditorServices #722](https://github.com/PowerShell/PowerShellEditorServices/pulls/722) -
  Add VSTS signing step
- [PowerShellEditorServices #717](https://github.com/PowerShell/PowerShellEditorServices/pulls/717) -
  increment version for prerelease
- [PowerShellEditorServices #715](https://github.com/PowerShell/PowerShellEditorServices/pulls/715) -
  Reduce allocations when parsing files  (Thanks @mattpwhite!)

@TylerLeonhardt
Copy link
Member

sweeeeeeeeet

@dragonwolf83
Copy link

dragonwolf83 commented Aug 16, 2018

Can we exclude increment versioning and update changelog messages? They are internal processes that adds noise and is not needed in a Change Log.

@rjmholt
Copy link
Contributor Author

rjmholt commented Aug 16, 2018

@dragonwolf83 yes, but not in this script

@rjmholt rjmholt merged commit 3eec223 into PowerShell:master Aug 17, 2018
@rjmholt rjmholt deleted the improve-changelog-script branch December 12, 2018 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants