Skip to content

Fix the quick return code in Eigen subroutines #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix the quick return code in Eigen subroutines #1034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions SRC/cgeesx.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,8 @@ SUBROUTINE CGEESX( JOBVS, SORT, SELECT, SENSE, N, A, LDA, SDIM,
*
IF( N.EQ.0 ) THEN
SDIM = 0
IF (WANTSE .OR. WANTSB) RCONDE = 1.0E0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not RCONDE = ONE? (same question for other precisions)

IF (WANTSV .OR. WANTSB) RCONDV = 0.0E0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RCONDV = ZERO? (same question for other precisions)

RETURN
END IF
*
Expand Down
7 changes: 5 additions & 2 deletions SRC/chbevx.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,8 +382,11 @@ SUBROUTINE CHBEVX( JOBZ, RANGE, UPLO, N, KD, AB, LDAB, Q, LDQ,
END IF
IF( M.EQ.1 ) THEN
W( 1 ) = REAL( CTMP1 )
IF( WANTZ )
$ Z( 1, 1 ) = CONE
IF( WANTZ ) THEN
Q( 1, 1 ) = ONE
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To have matching types: ONE -> CONE

Please also check precision 'z'.

Z( 1, 1 ) = ONE
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ONE -> CONE

IFAIL(1) = 0
ENDIF
END IF
RETURN
END IF
Expand Down
6 changes: 4 additions & 2 deletions SRC/cheevx.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,8 +390,10 @@ SUBROUTINE CHEEVX( JOBZ, RANGE, UPLO, N, A, LDA, VL, VU, IL,
W( 1 ) = REAL( A( 1, 1 ) )
END IF
END IF
IF( WANTZ )
$ Z( 1, 1 ) = CONE
IF( WANTZ ) THEN
Z( 1, 1 ) = ONE
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ONE -> CONE

IFAIL(1) = 0
ENDIF
RETURN
END IF
*
Expand Down
6 changes: 4 additions & 2 deletions SRC/chpevx.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,8 +341,10 @@ SUBROUTINE CHPEVX( JOBZ, RANGE, UPLO, N, AP, VL, VU, IL, IU,
W( 1 ) = REAL( AP( 1 ) )
END IF
END IF
IF( WANTZ )
$ Z( 1, 1 ) = CONE
IF( WANTZ ) THEN
Z( 1, 1 ) = CONE
IFAIL(1) = 0
ENDIF
RETURN
END IF
*
Expand Down
1 change: 1 addition & 0 deletions SRC/chpgvx.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,7 @@ SUBROUTINE CHPGVX( ITYPE, JOBZ, RANGE, UPLO, N, AP, BP, VL, VU,
*
* Quick return if possible
*
M = 0
IF( N.EQ.0 )
$ RETURN
*
Expand Down
2 changes: 2 additions & 0 deletions SRC/dgeesx.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,6 +421,8 @@ SUBROUTINE DGEESX( JOBVS, SORT, SELECT, SENSE, N, A, LDA, SDIM,
*
IF( N.EQ.0 ) THEN
SDIM = 0
IF (WANTSE .OR. WANTSB) RCONDE = 1.0D0
IF (WANTSV .OR. WANTSB) RCONDV = 0.0D0
RETURN
END IF
*
Expand Down
7 changes: 5 additions & 2 deletions SRC/dsbevx.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,8 +373,11 @@ SUBROUTINE DSBEVX( JOBZ, RANGE, UPLO, N, KD, AB, LDAB, Q, LDQ,
END IF
IF( M.EQ.1 ) THEN
W( 1 ) = TMP1
IF( WANTZ )
$ Z( 1, 1 ) = ONE
IF( WANTZ ) THEN
Q( 1, 1 ) = ONE
Z( 1, 1 ) = ONE
IFAIL(1) = ZERO
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To have matching types: IFAIL(1) = 0 (more occurrences in other files)

ENDIF
END IF
RETURN
END IF
Expand Down
6 changes: 4 additions & 2 deletions SRC/dspevx.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,8 +332,10 @@ SUBROUTINE DSPEVX( JOBZ, RANGE, UPLO, N, AP, VL, VU, IL, IU,
W( 1 ) = AP( 1 )
END IF
END IF
IF( WANTZ )
$ Z( 1, 1 ) = ONE
IF( WANTZ ) THEN
Z( 1, 1 ) = ONE
IFAIL(1) = ZERO
ENDIF
RETURN
END IF
*
Expand Down
6 changes: 4 additions & 2 deletions SRC/dsyevx.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,8 +378,10 @@ SUBROUTINE DSYEVX( JOBZ, RANGE, UPLO, N, A, LDA, VL, VU, IL,
W( 1 ) = A( 1, 1 )
END IF
END IF
IF( WANTZ )
$ Z( 1, 1 ) = ONE
IF( WANTZ ) THEN
Z( 1, 1 ) = ONE
IFAIL(1) = ZERO
ENDIF
RETURN
END IF
*
Expand Down
2 changes: 2 additions & 0 deletions SRC/sgeesx.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,8 @@ SUBROUTINE SGEESX( JOBVS, SORT, SELECT, SENSE, N, A, LDA, SDIM,
*
IF( N.EQ.0 ) THEN
SDIM = 0
IF (WANTSE .OR. WANTSB) RCONDE = 1.0E0
IF (WANTSV .OR. WANTSB) RCONDV = 0.0E0
RETURN
END IF
*
Expand Down
7 changes: 5 additions & 2 deletions SRC/ssbevx.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,8 +373,11 @@ SUBROUTINE SSBEVX( JOBZ, RANGE, UPLO, N, KD, AB, LDAB, Q, LDQ,
END IF
IF( M.EQ.1 ) THEN
W( 1 ) = TMP1
IF( WANTZ )
$ Z( 1, 1 ) = ONE
IF( WANTZ ) THEN
Q( 1, 1 ) = ONE
Z( 1, 1 ) = ONE
IFAIL(1) = ZERO
ENDIF
END IF
RETURN
END IF
Expand Down
6 changes: 4 additions & 2 deletions SRC/sspevx.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,8 +332,10 @@ SUBROUTINE SSPEVX( JOBZ, RANGE, UPLO, N, AP, VL, VU, IL, IU,
W( 1 ) = AP( 1 )
END IF
END IF
IF( WANTZ )
$ Z( 1, 1 ) = ONE
IF( WANTZ ) THEN
Z( 1, 1 ) = ONE
IFAIL(1) = ZERO
ENDIF
RETURN
END IF
*
Expand Down
6 changes: 4 additions & 2 deletions SRC/ssyevx.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,8 +379,10 @@ SUBROUTINE SSYEVX( JOBZ, RANGE, UPLO, N, A, LDA, VL, VU, IL,
W( 1 ) = A( 1, 1 )
END IF
END IF
IF( WANTZ )
$ Z( 1, 1 ) = ONE
IF( WANTZ ) THEN
Z( 1, 1 ) = ONE
IFAIL(1) = ZERO
ENDIF
RETURN
END IF
*
Expand Down
2 changes: 2 additions & 0 deletions SRC/zgeesx.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,8 @@ SUBROUTINE ZGEESX( JOBVS, SORT, SELECT, SENSE, N, A, LDA, SDIM,
*
IF( N.EQ.0 ) THEN
SDIM = 0
IF (WANTSE .OR. WANTSB) RCONDE = 1.0D0
IF (WANTSV .OR. WANTSB) RCONDV = 0.0D0
RETURN
END IF
*
Expand Down
7 changes: 5 additions & 2 deletions SRC/zhbevx.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,8 +382,11 @@ SUBROUTINE ZHBEVX( JOBZ, RANGE, UPLO, N, KD, AB, LDAB, Q, LDQ,
END IF
IF( M.EQ.1 ) THEN
W( 1 ) = DBLE( CTMP1 )
IF( WANTZ )
$ Z( 1, 1 ) = CONE
IF( WANTZ ) THEN
Q( 1, 1 ) = ONE
Z( 1, 1 ) = ONE
IFAIL(1) = 0
ENDIF
END IF
RETURN
END IF
Expand Down
6 changes: 4 additions & 2 deletions SRC/zheevx.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,8 +389,10 @@ SUBROUTINE ZHEEVX( JOBZ, RANGE, UPLO, N, A, LDA, VL, VU, IL,
W( 1 ) = DBLE( A( 1, 1 ) )
END IF
END IF
IF( WANTZ )
$ Z( 1, 1 ) = CONE
IF( WANTZ ) THEN
Z( 1, 1 ) = ONE
IFAIL(1) = 0
ENDIF
RETURN
END IF
*
Expand Down
6 changes: 4 additions & 2 deletions SRC/zhpevx.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,8 +341,10 @@ SUBROUTINE ZHPEVX( JOBZ, RANGE, UPLO, N, AP, VL, VU, IL, IU,
W( 1 ) = DBLE( AP( 1 ) )
END IF
END IF
IF( WANTZ )
$ Z( 1, 1 ) = CONE
IF( WANTZ ) THEN
Z( 1, 1 ) = CONE
IFAIL(1) = 0
ENDIF
RETURN
END IF
*
Expand Down
1 change: 1 addition & 0 deletions SRC/zhpgvx.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,7 @@ SUBROUTINE ZHPGVX( ITYPE, JOBZ, RANGE, UPLO, N, AP, BP, VL, VU,
*
* Quick return if possible
*
M = 0
IF( N.EQ.0 )
$ RETURN
*
Expand Down
Loading