Skip to content

Compatibility for ReflectionClass #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 88 commits into from
Jul 20, 2015
Merged

Compatibility for ReflectionClass #59

merged 88 commits into from
Jul 20, 2015

Conversation

asgrim
Copy link
Member

@asgrim asgrim commented Jul 12, 2015

This PR brings about "most" compatibility for ReflectionClass, thus merging this will finally resolve #7.

General

  • Rebase onto master before merge (Update CS rules #60 may cause conflict)
  • getParentClass
  • getDefaultProperties
  • getDocComment
  • getStartLine
  • getEndLine
  • hasConstant
  • hasMethod
  • hasProperty
  • isInternal
  • isUserDefined
  • isAbstract
  • isFinal
  • getModifiers

Trait-related

Interface-related

  • getInterfaceNames
  • getInterfaces
  • isInterface

Needs parent/interface/trait hierarchy

  • isCloneable
  • isInstance
  • isInstantiable
  • isIterateable
  • isSubClassOf
  • implementsInterface

Other stuff

  • Inject BetterReflection\Reflector\Reflector instead of a SourceLocator to things like getTraits, getInterfaces, getParentClass (and other related methods)

@@ -182,6 +210,22 @@ public function getMethod($methodName)
}

/**
* Does the class have the specified method method?
*
* @param $methodName
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

string

Ocramius and others added 23 commits July 20, 2015 15:56
…stantiable

`ReflectionClass#isInstantiable()`, `ReflectionClass#isCloneable()`, `ReflectionClass#isIterateable()` and fixes to `ReflectionClass#getInterfaces()` based on multiple inheritance in interfaces
…ly uses the passed in reflector every time
…oval

Source locator parameter removal when traversing reflection objects
@asgrim asgrim changed the title [WIP] Compatibility for ReflectionClass Compatibility for ReflectionClass Jul 20, 2015
@asgrim asgrim assigned Ocramius and unassigned asgrim Jul 20, 2015
Ocramius added a commit that referenced this pull request Jul 20, 2015
Compatibility for ReflectionClass
@Ocramius Ocramius merged commit 396c35d into master Jul 20, 2015
@Ocramius Ocramius deleted the compat-reflectionclass branch July 20, 2015 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to become "mostly" compatible with PHP's Reflection API
2 participants