-
Notifications
You must be signed in to change notification settings - Fork 137
Compatibility for ReflectionClass #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 12, 2015
c8f6304
to
f2d54d9
Compare
Merged
…ode helper methods for internally reconstructing traits and interfaces
…ntor/TypeResolver PR
@@ -182,6 +210,22 @@ public function getMethod($methodName) | |||
} | |||
|
|||
/** | |||
* Does the class have the specified method method? | |||
* | |||
* @param $methodName |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
string
…id inheritance tree is encountered
… should lead to a failure
…ld lead to a failure
…class should lead to a failure
…nvalid (throwing an exception)
…stantiable `ReflectionClass#isInstantiable()`, `ReflectionClass#isCloneable()`, `ReflectionClass#isIterateable()` and fixes to `ReflectionClass#getInterfaces()` based on multiple inheritance in interfaces
… reflection objects
…ly uses the passed in reflector every time
…oval Source locator parameter removal when traversing reflection objects
Ocramius
added a commit
that referenced
this pull request
Jul 20, 2015
Compatibility for ReflectionClass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings about "most" compatibility for
ReflectionClass
, thus merging this will finally resolve #7.General
Trait-related
Interface-related
Needs parent/interface/trait hierarchy
Other stuff
BetterReflection\Reflector\Reflector
instead of aSourceLocator
to things likegetTraits
,getInterfaces
,getParentClass
(and other related methods)