Skip to content
This repository was archived by the owner on Mar 13, 2019. It is now read-only.

Alpine support for composer/composer (PHP7) #56

Merged
merged 3 commits into from
Apr 24, 2016
Merged

Alpine support for composer/composer (PHP7) #56

merged 3 commits into from
Apr 24, 2016

Conversation

sylus
Copy link
Contributor

@sylus sylus commented Apr 22, 2016

Updated P.R. based off of php:7.0-alpine

php:7.0-alpine; 382.7 MB
composer:composer-alpine: 465.4 MB

Ref: #19

This one matches closely the other Dockerfiles and leveragers docker-php-ext to install addons instead of package manager. Talk about diferences between using source vs apk install is here: docker-library/php#206

Eventually the parent image will be much smaller once some build dependencies are removed during runtime here:

docker-library/php#206

sylus added 3 commits April 22, 2016 18:39
Updated P.R. based off of php:7.0-alpine

php:7.0-alpine; 382.7 MB
composer:composer-alpine: 465.4 MB
@RobLoach
Copy link
Owner

This is great! I love the approach taken here. What would the tags be for this? 1.0.0-alpine, master-alpine, alpine?

@sylus
Copy link
Contributor Author

sylus commented Apr 23, 2016

The tags I currently have are:

composer/composer:base-alpine
composer/composer-alpine
composer/composer:1-alpine
composer/composer:1.0-alpine
composer/composer:1.0.0-alpine
composer/composer:master-alpine

Of course if anything missing just let me know :)

I didn't do other versions earlier then 1.0.0 but can circle back for anything missing as well as add a docs section. I tried to keep the alpine directory layout similar to the official docker images so tags would be like this one: https://hub.docker.com/_/php/

Again once docker-library/php#206 is finalized I am expecting the image to be under 300MB but for now everything still looks good :)

@RobLoach
Copy link
Owner

Very cool. Come to think of it, @pirog and I just opened up the php5 branch, to allow switching to PHP5 (composer/composer:php5). We may be able to do something similar to make upgrading easier, since you'd just pull changes from the master branch down.

Thoughts? Should we maintain the variants in the master branch, or in different branches?

@sylus
Copy link
Contributor Author

sylus commented Apr 23, 2016

I think it makes sense to keep the variants in each branch (master + php5) so there will be an alpine folder for the master branch and if this gets accepted I can submit a P.R. for alpine sub folders in the php5 branch.?

I know the standard that official docker-library is using is just adding an alpine sub folder but they really only use the main master branch.

I'd happily do a alpine branch though if that is way you want to go!

@RobLoach
Copy link
Owner

RobLoach commented Apr 23, 2016

Ah, so master (tracking php7) would have an alpine folder, and php5 branch would also have an alpine folder.

composer/composer:php5-alpine
composer/composer:1-php5-alpine
composer/composer:1.0-php5-alpine
composer/composer:1.0.0-php5-alpine
... etc

That make sense? Or would -php5 be after alpine?

@sylus
Copy link
Contributor Author

sylus commented Apr 23, 2016

Yeah that is what I was thinking. I have no preference for the php5 variation but I think it makes sense to have alpine at the end as your example(s) above illustrate ^_^

@RobLoach RobLoach merged commit 88262d6 into RobLoach:master Apr 24, 2016
@RobLoach
Copy link
Owner

RobLoach commented Apr 24, 2016

Merged! Docker Hub is thinkin' about it:
https://hub.docker.com/r/composer/composer/builds/

@sylus
Copy link
Contributor Author

sylus commented Apr 24, 2016

Awesome! thank you so much!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants