-
Notifications
You must be signed in to change notification settings - Fork 48
Alpine support for composer/composer (PHP7) #56
Conversation
Updated P.R. based off of php:7.0-alpine php:7.0-alpine; 382.7 MB composer:composer-alpine: 465.4 MB
This is great! I love the approach taken here. What would the tags be for this? |
The tags I currently have are:
Of course if anything missing just let me know :) I didn't do other versions earlier then 1.0.0 but can circle back for anything missing as well as add a docs section. I tried to keep the alpine directory layout similar to the official docker images so tags would be like this one: https://hub.docker.com/_/php/ Again once docker-library/php#206 is finalized I am expecting the image to be under 300MB but for now everything still looks good :) |
Very cool. Come to think of it, @pirog and I just opened up the Thoughts? Should we maintain the variants in the master branch, or in different branches? |
I think it makes sense to keep the variants in each branch (master + php5) so there will be an alpine folder for the master branch and if this gets accepted I can submit a P.R. for alpine sub folders in the php5 branch.? I know the standard that official docker-library is using is just adding an alpine sub folder but they really only use the main master branch. I'd happily do a alpine branch though if that is way you want to go! |
Ah, so
That make sense? Or would |
Yeah that is what I was thinking. I have no preference for the php5 variation but I think it makes sense to have alpine at the end as your example(s) above illustrate ^_^ |
Merged! Docker Hub is thinkin' about it: |
Awesome! thank you so much! |
Updated P.R. based off of php:7.0-alpine
php:7.0-alpine; 382.7 MB
composer:composer-alpine: 465.4 MB
Ref: #19
This one matches closely the other Dockerfiles and leveragers docker-php-ext to install addons instead of package manager. Talk about diferences between using source vs apk install is here: docker-library/php#206
Eventually the parent image will be much smaller once some build dependencies are removed during runtime here:
docker-library/php#206