Skip to content

fix CVE-2022-3517 #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Conversation

dmeyer-pfg
Copy link

Fixes CVE-2022-3517 by upgrading glob to include the upgrade to minimatch version greater than 3.0.4.

Details: https://www.mend.io/vulnerability-database/CVE-2022-3517

Additional notes: I had to run npm install --force in order to update the lock file

@draperunner
Copy link

If you run npm install with npm v6, you won't have to use --force, and the lock file version won't be upgraded from 1 to 2. I guess you have run npm install with npm v8.

I agree that it's time to upgrade the package-lock.json file to v2, but maybe that's a better fit for another PR.

@RonRadtke RonRadtke merged commit 6120f48 into RonRadtke:master Nov 3, 2022
@RonRadtke
Copy link
Owner

RonRadtke commented Nov 3, 2022

Don't see any problem in just increasing it directly to v2 - otherwise I would have done it manually now
Thanks for the PR @dmeyer-pfg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants