Skip to content

Make CI disallow leftover debugging code #511

Open
@niklasmohrin

Description

@niklasmohrin

See #483 (comment)

A CI job could ensure that there are no dbg! (or pr_info!, etc.) calls left in pushed code would be a nice addition to the test suite. I have three high level ideas for how to accomplish this, but I haven't checked the applicability of any of them:

  1. Use rust-analyzer to find all references of the disallowed methods
  2. I believe there are certain clippy lints similar to what we want (disallowed-methods or so, relatively new) that could potentially be used
  3. Just grep over all of the Rust code / all *.rs files

While the last option is probably simplest, it may not be the cleanest. (note that these are just my first ideas, anyone implementing this can of course diverge from them :D ).

Metadata

Metadata

Assignees

No one assigned

    Labels

    • miscRelated to other topics (e.g. CI).

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions