Skip to content

Update package versions and Python version #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 14, 2021
Merged

Update package versions and Python version #259

merged 3 commits into from
Oct 14, 2021

Conversation

jsemearns
Copy link
Contributor

@jsemearns jsemearns commented Oct 14, 2021 •
edited
Loading

  • Ran generate_requirements script
  • Bump python version to 3.10

Fix #250

@jsemearns
Update package versions and Python version
18b1066 
- Ran generate_requirements.txt
- Bump python version to 3.10
@jsemearns jsemearns requested a review from hillairet October 14, 2021 05:37
@jsemearns jsemearns self-assigned this Oct 14, 2021
@jsemearns
Copy link
Contributor Author

@hillairet I didn't bump flake8 and isort (with their respective dependencies) to the latest version since there's an issue with the major release of isort. Running dev.sh validate on the latest versions will throw this error: ImportError: cannot import name 'SortImports' from 'isort' (/usr/local/lib/python3.10/site-packages/isort/__init__.py)

hillairet
hillairet approved these changes Oct 14, 2021
View reviewed changes
Copy link
Collaborator

@hillairet hillairet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thank you for doing this!
Did you notice how the appdirs dependency was replaced by platformdirs?
Regenerating the requirements file is definitely the way to go!

hillairet
hillairet requested changes Oct 14, 2021
View reviewed changes
Copy link
Collaborator

@hillairet hillairet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I set approved but make sure to fix the base image version!

@jsemearns jsemearns merged commit e5adf36 into main Oct 14, 2021
@jsemearns jsemearns deleted the feature/upgrade-versions branch November 2, 2021 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hillairet hillairet hillairet requested changes

Assignees

@jsemearns jsemearns

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade all packages and make version 4.3
2 participants
@jsemearns @hillairet