Skip to content

Consider non-timeseries parameters to be ContinuousTimeseries #3794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Consider non-timeseries parameters to be ContinuousTimeseries #3794

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/systems/abstractsystem.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,10 +300,10 @@ function has_parameter_dependency_with_lhs(sys, sym)
end

function _all_ts_idxs!(ts_idxs, ::NotSymbolic, sys, sym)
if is_variable(sys, sym) || is_independent_variable(sys, sym)
push!(ts_idxs, ContinuousTimeseries())
elseif is_timeseries_parameter(sys, sym)
if is_timeseries_parameter(sys, sym)
push!(ts_idxs, timeseries_parameter_index(sys, sym).timeseries_idx)
elseif is_variable(sys, sym) || is_independent_variable(sys, sym) || is_parameter(sys, sym)
push!(ts_idxs, ContinuousTimeseries())
end
end
# Need this to avoid ambiguity with the array case
Expand All @@ -315,10 +315,10 @@ for traitT in [
allsyms = vars(sym; op = Symbolics.Operator)
for s in allsyms
s = unwrap(s)
if is_variable(sys, s) || is_independent_variable(sys, s)
push!(ts_idxs, ContinuousTimeseries())
elseif is_timeseries_parameter(sys, s)
if is_timeseries_parameter(sys, s)
push!(ts_idxs, timeseries_parameter_index(sys, s).timeseries_idx)
elseif is_variable(sys, s) || is_independent_variable(sys, s) || is_parameter(sys, sym)
push!(ts_idxs, ContinuousTimeseries())
elseif is_time_dependent(sys) && iscall(s) && issym(operation(s)) &&
length(arguments(s)) == 1 && is_variable(sys, operation(s)(get_iv(sys)))
# DDEs case, to detect x(t - k)
Expand Down
Loading