Skip to content

Use the new SciMLBenchmarks BuildKite system #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 24, 2021
Merged

Use the new SciMLBenchmarks BuildKite system #398

merged 3 commits into from
May 24, 2021

Conversation

MaxCan-Code
Copy link
Contributor

No description provided.

@ChrisRackauckas
Copy link
Member

We need to update this repo to use the new SciMLBenchmarks BuildKite system.

@ChrisRackauckas
Copy link
Member

Would you be interested in helping with that?

@MaxCan-Code
Copy link
Contributor Author

Sure, I'll take a look at the .buildkite. I can also merge the changes from src/SciMLBenchmarks.jl into src/SciMLTutorials.jl

@ChrisRackauckas
Copy link
Member

If you have any questions, @staticfloat is the guy to ask.

@codecov
Copy link

codecov bot commented May 22, 2021

Codecov Report

Merging #398 (01b77f5) into master (f3fa800) will increase coverage by 12.97%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #398       +/-   ##
===========================================
+ Coverage   65.71%   78.68%   +12.97%     
===========================================
  Files           1        1               
  Lines          70       61        -9     
===========================================
+ Hits           46       48        +2     
+ Misses         24       13       -11     
Impacted Files Coverage Δ
src/SciMLTutorials.jl 78.68% <100.00%> (+12.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3fa800...01b77f5. Read the comment docs.

@MaxCan-Code MaxCan-Code changed the title resolve #377 use the new SciMLBenchmarks BuildKite system May 22, 2021
@MaxCan-Code MaxCan-Code changed the title use the new SciMLBenchmarks BuildKite system Use the new SciMLBenchmarks BuildKite system May 22, 2021
@ChrisRackauckas
Copy link
Member

This still isn't running the BuildKite runs. We also need to make the appropriate output repo. @staticfloat might need to take a look.

@MaxCan-Code
Copy link
Contributor Author

If you haven't, you might need to set up a new pipeline for this repo

@ChrisRackauckas
Copy link
Member

Just created.

@MaxCan-Code
Copy link
Contributor Author

We also need to make the appropriate output repo.

Done in my third commit, though SciMLTutorialsOutput doesn't seem to exist yet

@MaxCan-Code
Copy link
Contributor Author

This still isn't running the BuildKite runs.

The .buildkite folder isn't in this repo yet, @ staticfloat can have a look before merging

@ChrisRackauckas ChrisRackauckas merged commit 01b77f5 into SciML:master May 24, 2021
@ChrisRackauckas
Copy link
Member

Oh snap, your branch was named master? 🤦 please don't do that. But haha that's fine.

I setup the output repo, moved the webserver, and moved the outputs over to that. So hopefully things work? It's worth giving it a try.

@MaxCan-Code MaxCan-Code deleted the master branch May 24, 2021 11:45
@MaxCan-Code MaxCan-Code restored the master branch May 24, 2021 12:10
@MaxCan-Code MaxCan-Code deleted the master branch May 25, 2021 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants