Rb make bidi timeout configurable

[aguspe]

User description

🔗 Related Issues

This aims to fix #15620 until a timeout implementation for BiDi happens

💥 What does this PR do?

This PR adds support for changing the WebSocket timeout through options.

🔧 Implementation Notes

For now, the implementation is temporary, and I'm trying to find the best way to make it work. I will update this before finishing this draft

🔄 Types of changes

• Bug fix (backwards compatible)

---

PR Type

Enhancement

---

Description

• Add configurable WebSocket timeout options for BiDi connections

• Support web_socket_timeout and web_socket_interval parameters

• Pass timeout configuration through options chain

• Add integration test for timeout behavior

---

Diagram Walkthrough

flowchart LR
  Options["Options Class"] -- "adds timeout options" --> BiDiBridge["BiDi Bridge"]
  BiDiBridge -- "passes ws_options" --> BiDi["BiDi Class"]
  BiDi -- "forwards options" --> WebSocket["WebSocket Connection"]
  WebSocket -- "configures timeout" --> Wait["Wait Object"]

Loading

File Walkthrough

	Relevant files

---

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Naming Inconsistency The capability keys use 'ws:responseTimeout' and 'ws:responseInterval' but the options hash uses 'response_timeout' and 'response_interval'. This inconsistency could lead to configuration not being passed correctly. ws_options = { response_timeout: capabilities['ws:responseTimeout'], response_interval: capabilities['ws:responseInterval'] }.compact Key Mismatch The WebSocket options are mapped to 'ws:response_timeout' and 'ws:response_interval' in as_json method, but BiDiBridge expects 'ws:responseTimeout' and 'ws:responseInterval' with different casing. options['ws:response_timeout'] = options.delete(:web_socket_timeout) if options[:web_socket_timeout] options['ws:response_interval'] = options.delete(:web_socket_interval) if options[:web_socket_interval] Test Logic Issue The test sets web_socket_interval to 1 second but web_socket_timeout to 0.1 seconds, which means the timeout will occur before the first interval check. This may not properly test the timeout functionality. reset_driver!(web_socket_url: true, web_socket_timeout: 0.1, web_socket_interval: 1) do |driver| expect { driver.navigate.to url_for('sleep?time=0.2') }.to raise_error(Selenium::WebDriver::Error::TimeoutError) end

[qodo-merge-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Fix capability key mismatch The capability keys should match the ones defined in the options mapping. The keys should be 'ws:response_timeout' and 'ws:response_interval' to match the mapping in as_json method. rb/lib/selenium/webdriver/remote/bidi_bridge.rb [30-33] ws_options = { - response_timeout: capabilities['ws:responseTimeout'], - response_interval: capabilities['ws:responseInterval'] + response_timeout: capabilities['ws:response_timeout'], + response_interval: capabilities['ws:response_interval'] }.compact Apply / Chat Suggestion importance[1-10]: 9 __ Why: The suggestion correctly identifies a bug where the capability keys being read (ws:responseTimeout) do not match the keys being set in options.rb (ws:response_timeout), which would cause the new timeout feature to fail.	High
Update