Skip to content

Modified text of previous conference and added conf archive website link which was created by Diego #2378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2025

Conversation

pallavigitwork
Copy link
Member

@pallavigitwork pallavigitwork commented Jul 10, 2025

User description

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Modified text of previous conference and added conf archive website link which was created by Diego

Description

Modified text of previous conference and added conf archive website link which was created by Diego

Motivation and Context

Modified text of previous conference and added conf archive website link which was created by Diego

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

Documentation


Description

  • Updated conference text from future to past tense

  • Added archive link for previous Selenium conferences


Changes diagram

flowchart LR
  A["Conference Text"] --> B["Updated to Past Tense"]
  C["New Archive Link"] --> D["Added Conference Archive Button"]
  B --> E["Updated Events Page"]
  D --> E
Loading

Changes walkthrough 📝

Relevant files
Documentation
_index.html
Updated conference section with archive link                         

website_and_docs/content/events/_index.html

  • Changed conference text from future to past tense
  • Added new button linking to conference archive website
  • Updated verb tenses to reflect completed event
  • +10/-3   

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link

    netlify bot commented Jul 10, 2025

    👷 Deploy request for selenium-dev pending review.

    Visit the deploys page to approve it

    Name Link
    🔨 Latest commit aab48fa

    @pallavigitwork pallavigitwork self-assigned this Jul 10, 2025
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Date Inconsistency

    The text mentions the conference was held in March 2025, but today's date is July 2025. This creates confusion about whether the event is past or future. The date should be corrected to reflect the actual past conference date.

    held in Valencia, Spain on March 26-28, 2025. The Selenium Conference
    and Appium Conference brought together Selenium and Appium developers & enthusiasts
    Mixed Tenses

    While most text was updated to past tense, some phrases still mix tenses inconsistently. The sentence structure could be improved for better clarity and consistency.

    The last flagship Selenium conference was held together
    with Appium conference. It was an in-person event and was
    held in Valencia, Spain on March 26-28, 2025. The Selenium Conference
    and Appium Conference brought together Selenium and Appium developers & enthusiasts
    from around the world to share ideas, socialize, and work together on
    advancing the present and future success of the project.

    Copy link
    Contributor

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    General
    Fix inconsistent HTML indentation

    The indentation is inconsistent with the surrounding code structure. Align the
    div element with the previous selenium-button-container for better code
    formatting.

    website_and_docs/content/events/_index.html [63-64]

     <br>
    -     <div class="selenium-button-container justify-content-md-end">
    +    <div class="selenium-button-container justify-content-md-end">
    • Apply / Chat
    Suggestion importance[1-10]: 3

    __

    Why: The suggestion correctly points out an indentation inconsistency, which is a minor style issue, but the provided improved_code does not follow the indentation of the surrounding elements.

    Low
    • More

    @pallavigitwork pallavigitwork merged commit 1935ba1 into SeleniumHQ:trunk Jul 10, 2025
    3 checks passed
    selenium-ci added a commit that referenced this pull request Jul 10, 2025
    …ink which was created by Diego (#2378)
    
    * updates text for selenium conference section and added link of webpage created by Diego which lists previous selenium conferences
    
    * [deploy site] modified text as per prev conf and added link of conf archive created by Diego 1935ba1
    @pallavigitwork pallavigitwork deleted the addConfArchive-pal branch July 15, 2025 07:04
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant