Skip to content

[deploy site] changed links to open in new window/tab #2379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025

Conversation

pallavigitwork
Copy link
Member

@pallavigitwork pallavigitwork commented Jul 15, 2025

User description

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

changed links to open in new window/tab

Description

changed links to open in new window/tab

Motivation and Context

changed links to open in new window/tab

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

Enhancement


Description

  • Added target="_blank" attribute to external links

  • Modified conference and archive links to open in new tabs


Changes diagram

flowchart LR
  A["Events Page Links"] --> B["Add target='_blank'"] --> C["Links Open in New Tab"]
Loading

Changes walkthrough 📝

Relevant files
Enhancement
_index.html
Add target="_blank" to external links                                       

website_and_docs/content/events/_index.html

  • Added target="_blank" attribute to Selenium Conference link
  • Added target="_blank" attribute to conference archive link
  • +2/-2     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link

    netlify bot commented Jul 15, 2025

    👷 Deploy request for selenium-dev pending review.

    Visit the deploys page to approve it

    Name Link
    🔨 Latest commit 01fdf22

    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 Security concerns

    Tabnabbing vulnerability:
    Links with target="_blank" without rel="noopener noreferrer" can allow the opened page to access the original page's window object, potentially leading to tabnabbing attacks where malicious sites could redirect the original page to a phishing site.

    ⚡ Recommended focus areas for review

    Missing Security

    External links with target="_blank" should include rel="noopener noreferrer" for security reasons to prevent the new page from accessing the window.opener property and potential tabnabbing attacks.

      <a href="https://seleniumconf.com/" class="selenium-button selenium text-uppercase fw-bold" target="_blank">
        Learn more
        <i class="ps-3 fas fa-caret-right"></i>
      </a>
    </div>
    <br>
     <div class="selenium-button-container justify-content-md-end">
      <a href="https://www.selenium.dev/conf-archive/" class="selenium-button selenium text-uppercase fw-bold" target="_blank">

    Copy link
    Contributor

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    Security
    Add security attributes to external links

    Add rel="noopener noreferrer" attribute for security when using target="_blank".
    This prevents the new page from accessing the original window object and
    protects against potential security vulnerabilities.

    website_and_docs/content/events/_index.html [58]

    -<a href="https://seleniumconf.com/" class="selenium-button selenium text-uppercase fw-bold" target="_blank">
    +<a href="https://seleniumconf.com/" class="selenium-button selenium text-uppercase fw-bold" target="_blank" rel="noopener noreferrer">
    • Apply / Chat
    Suggestion importance[1-10]: 8

    __

    Why: The suggestion correctly points out a security best practice by adding rel="noopener noreferrer" to a link with target="_blank", which mitigates potential tabnabbing vulnerabilities.

    Medium
    • More

    @pallavigitwork pallavigitwork merged commit 485cf89 into SeleniumHQ:trunk Jul 15, 2025
    3 checks passed
    @pallavigitwork pallavigitwork deleted the newLink-pal branch July 15, 2025 07:12
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant