Skip to content

Update minimum supported Java version #2385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

alaahong
Copy link
Member

@alaahong alaahong commented Jul 20, 2025

User description

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Update View the minimum supported Java version

Motivation and Context

As SeleniumHQ/selenium#12843 and https://www.selenium.dev/blog/2023/selenium-4-14-released/ mentioned, latest Selenium had been based on Java 11+, so just update the minimum version to avoid confused.

As below PR provided a confused line, just update and sync to all pages.
#2353

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

Documentation


Description

  • Update Java version reference link across documentation files

  • Fix GitHub link to point to correct line number

  • Sync changes across multiple language translations


Diagram Walkthrough

flowchart LR
  A["Documentation Files"] --> B["Update GitHub Link"]
  B --> C["Line #13 to #32"]
  C --> D["Multiple Languages"]
  D --> E["English, Japanese, Portuguese, Chinese"]
Loading

File Walkthrough

Relevant files
Documentation
install_library.en.md
Fix Java version link reference                                                   

website_and_docs/content/documentation/webdriver/getting_started/install_library.en.md

+1/-1     
install_library.ja.md
Fix Java version link reference (Japanese)                             

website_and_docs/content/documentation/webdriver/getting_started/install_library.ja.md

+1/-1     
install_library.pt-br.md
Fix Java version link reference (Portuguese)                         

website_and_docs/content/documentation/webdriver/getting_started/install_library.pt-br.md

+1/-1     
install_library.zh-cn.md
Fix Java version link reference (Chinese)                               

website_and_docs/content/documentation/webdriver/getting_started/install_library.zh-cn.md

+1/-1     

As SeleniumHQ/selenium#12843 and https://www.selenium.dev/blog/2023/selenium-4-14-released/ mentioned, latest Selenium had been based on Java 11+, so just update the minimum version to avoid confused.
Copy link

netlify bot commented Jul 20, 2025

👷 Deploy request for selenium-dev pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 971dcc0

Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Translation Issue

The Chinese translation uses English word "here" instead of Chinese equivalent. Should be consistent with the translation approach used in other language files.

查看该库所支持java的最低版本 [here](https://github.com/SeleniumHQ/selenium/blob/trunk/.bazelrc#L32).

Copy link
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

@alaahong alaahong merged commit a1eac3d into SeleniumHQ:trunk Jul 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant