-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add: Adding initial document for Page load strategy #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Sri Harsha <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @harsha509, I left a few minor comments.
Also, can you please check if the strategies work both in Chrome and Firefox at least? I remember that both browsers did not support all of them.
docs_source_files/content/webdriver/page_loading_strategy.de.md
Outdated
Show resolved
Hide resolved
docs_source_files/content/webdriver/page_loading_strategy.de.md
Outdated
Show resolved
Hide resolved
docs_source_files/content/webdriver/page_loading_strategy.de.md
Outdated
Show resolved
Hide resolved
docs_source_files/content/webdriver/page_loading_strategy.de.md
Outdated
Show resolved
Hide resolved
docs_source_files/content/webdriver/page_loading_strategy.de.md
Outdated
Show resolved
Hide resolved
Hi @diemol, Thanks for the update. I have tested the code samples in chrome only. Will check in firefox and will provide the update. Also will update the suggested changes. Regards, |
Hi @diemol, I've tested the code sample with firefox 70.0.1 with selenium4-alpha-5 JS bindings and it worked as expected. Please let me know if any additional info is required. Regards, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for double-checking @harsha509!
Thanks for reviewing @diemol. |
Description
Adding new document for webdriver -> page load strategy with Java and JS code examples
Types of changes
Checklist