Skip to content

Submitting a change to tbis file f #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Submitting a change to tbis file f #247

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 20, 2020

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

@claassistantio
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @CGilbert357,

Thanks for the PR.

Can you please let us know what this PR is about ?. I see a change in title from 'Grid' to 'Grids' and grid index page content is removed.

Usually, Selenium Grid is a single concept that allows users to run tests in different machines and different browsers which includes (client, hub, and nodes). I don't see any purpose to change the title to grids in the documentation.

Regards,
Harsha

@diemol
Copy link
Member

diemol commented Feb 21, 2020

@CGilbert357 feel free to reach out to us at the IRC/Slack channel in case you need help. It seems this PR was sent by mistake (as also some other of your recent GitHub activity).
I'll close this for now.

@diemol diemol closed this Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants