Skip to content

Add: Adding Ruby code sample for page_load_strategy #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2020
Merged

Add: Adding Ruby code sample for page_load_strategy #248

merged 1 commit into from
Feb 21, 2020

Conversation

harsha509
Copy link
Member

@harsha509 harsha509 commented Feb 21, 2020 •
edited
Loading

Description

Added ruby code samples for page_load_strategy. Code samples tested with selenium-4-4.0.0alpha4 [ruby] in chrome and firefox

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

@harsha509 harsha509 changed the title Add: Adding Ruby code sample for page_load_startegy Add: Adding Ruby code sample for page_load_strategy Feb 21, 2020
diemol
diemol approved these changes Feb 21, 2020
View reviewed changes
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @harsha509!

@diemol diemol merged commit 6ab8f1b into SeleniumHQ:master Feb 21, 2020
@harsha509 harsha509 deleted the page_load_strategy_code branch February 22, 2020 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diemol diemol diemol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harsha509 @diemol