Skip to content

Modify: Updating links for zh-cn #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 7, 2020
Merged

Modify: Updating links for zh-cn #286

merged 2 commits into from
Mar 7, 2020

Conversation

harsha509
Copy link
Member

@harsha509 harsha509 commented Mar 6, 2020 •
edited
Loading

Hi @diemol,

I just had a thought on this. As links are available for translated languages. i have updated for zh-cn

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

diemol
diemol approved these changes Mar 7, 2020
View reviewed changes
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thank you @harsha509!

@diemol diemol merged commit 6239ee5 into SeleniumHQ:master Mar 7, 2020
@harsha509 harsha509 deleted the updating_links branch March 12, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diemol diemol diemol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harsha509 @diemol