Skip to content

Add spanish translations #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 29, 2020

Conversation

ivanrodjr
Copy link
Contributor

Description

  • Add spanish translation to waits and alerts sites

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

Seems latest version of Hugo (local) does not supports raw html anynmore
since its using a new markdown rendering engine 'goldmark'. This causes
the alerts and prompts in this site to only display the plain text
without the html functionality attached. Did not add the fix in the
config file to mantain server compatibility and unintended side effects.
Fix:

https://discourse.gohugo.io/t/raw-html-getting-omitted-in-0-60-0/22032
Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ivanrodjr !

@harsha509 harsha509 merged commit 9cbaebc into SeleniumHQ:master Mar 29, 2020
@ivanrodjr ivanrodjr deleted the add-spanish-translations branch March 30, 2020 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants