Skip to content

V2.0.0, refactored to add config options and table creation #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 27, 2019
Merged

V2.0.0, refactored to add config options and table creation #3

merged 2 commits into from
Jul 27, 2019

Conversation

bflorian
Copy link
Contributor

Refactored to provide more flexible configuration options to better support single table
schemas and alternative ways of configuring AWS credentials.

Also added support for a state table entry for storing arbitrary installed app data (though SDK changes will be needed to expose that to SmartApps)

This is a breaking change as far as configuring the context store is concerned, but compatible with the
older version and existing SDK as far as reading and writing context is concerned.

@bflorian bflorian requested a review from erodewald July 19, 2019 15:56
rossiam
rossiam reviewed Jul 25, 2019
View reviewed changes
@erodewald erodewald mentioned this pull request Jul 25, 2019
Closed
erodewald
erodewald requested changes Jul 26, 2019
View reviewed changes
Copy link
Member

@erodewald erodewald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally very excited for this additional functionality. Storing arbitrary data in state is hugely useful to config.

@bflorian
Copy link
Contributor Author

Made requested changes

@erodewald erodewald merged commit cf16295 into SmartThingsCommunity:master Jul 27, 2019
smartthingspi added a commit that referenced this pull request Jul 28, 2019
@smartthingspi
chore(release): 1.0.0 [skip ci]
8d86af3 
# 1.0.0 (2019-07-28)

### Bug Fixes

* formatting, documentation, add ci, tests ([#6](#6)) ([281af90](281af90))
* missing packages, remove snyk ([#7](#7)) ([cc5a075](cc5a075))

### Features

* V2.0.0, refactored to add config options and table creation ([#3](#3)) ([cf16295](cf16295))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossiam rossiam rossiam left review comments

@erodewald erodewald erodewald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bflorian @erodewald @rossiam