DEVORTEX-5439 add webhooks api #125
Conversation
| interface SubscriptionSecretDto { | ||
| payloadSecret: string; | ||
| } | ||
|
|
||
| export { SubscriptionSecretDto }; |
There was a problem hiding this comment.
no actions points: weird naming. it's already clear this secret is in payload.
| enableSubscription( | ||
| accountUid: string, | ||
| subscriptionUid: string | ||
| ): Promise<void> { | ||
| return this.makeRequest( | ||
| "post", | ||
| `${this.entrypoint}/accounts/${accountUid}/subscriptions/${subscriptionUid}/enable` | ||
| ); | ||
| } | ||
|
|
||
| disableSubscription( | ||
| accountUid: string, | ||
| subscriptionUid: string | ||
| ): Promise<void> { | ||
| return this.makeRequest( | ||
| "post", | ||
| `${this.entrypoint}/accounts/${accountUid}/subscriptions/${subscriptionUid}/disable` | ||
| ); | ||
| } | ||
|
|
||
| testSubscription( | ||
| accountUid: string, | ||
| subscriptionUid: string | ||
| ): Promise<void> { | ||
| return this.makeRequest( | ||
| "post", | ||
| `${this.entrypoint}/accounts/${accountUid}/subscriptions/${subscriptionUid}/test` | ||
| ); | ||
| } |
There was a problem hiding this comment.
I remember initial arch review but have you guys arranged API review? These verbs in endpoints look strange (test/enable/disable/etc)
There was a problem hiding this comment.
@dnetrebenko-smartling could you please answer?
There was a problem hiding this comment.
we passed api review.all these actions (enable/disable/test) are business actions for subscriptions. do you have any ideas how to changes them?
There was a problem hiding this comment.
I do, but since api review is passed and endpoints are approved - I'm ok to leave these as is.
|
is this still in work (draft) or it waits for approves? |
There was a problem hiding this comment.
answering this: #125 (comment)
we are waiting for all endpoints implemented on the backend side
No description provided.