Skip to content

feat: option to skip fused kernels #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 26, 2025
Merged

feat: option to skip fused kernels #128

merged 5 commits into from
Jun 26, 2025

Conversation

MilesCranmer
Copy link
Member

Copy link
Contributor

github-actions bot commented May 26, 2025

Benchmark Results (Julia v1)

Time benchmarks
master ecb6117... master / ecb6117...
eval/ComplexF32/evaluation 7.29 ± 0.51 ms 7.23 ± 0.52 ms 1.01 ± 0.1
eval/ComplexF64/evaluation 10.7 ± 0.93 ms 10.8 ± 0.94 ms 0.99 ± 0.12
eval/Float32/derivative 11.9 ± 0.67 ms 11.6 ± 0.69 ms 1.03 ± 0.084
eval/Float32/derivative_turbo 12 ± 0.79 ms 11.6 ± 0.76 ms 1.03 ± 0.096
eval/Float32/evaluation 2.8 ± 0.28 ms 2.74 ± 0.27 ms 1.02 ± 0.14
eval/Float32/evaluation_bumper 0.582 ± 0.018 ms 0.581 ± 0.02 ms 1 ± 0.047
eval/Float32/evaluation_turbo 0.538 ± 0.032 ms 0.542 ± 0.03 ms 0.992 ± 0.08
eval/Float32/evaluation_turbo_bumper 0.582 ± 0.016 ms 0.582 ± 0.018 ms 1 ± 0.041
eval/Float64/derivative 14.8 ± 0.97 ms 14.7 ± 1.1 ms 1 ± 0.1
eval/Float64/derivative_turbo 14.9 ± 1.1 ms 14.7 ± 1 ms 1.02 ± 0.11
eval/Float64/evaluation 3.15 ± 0.35 ms 3.17 ± 0.33 ms 0.993 ± 0.15
eval/Float64/evaluation_bumper 1.19 ± 0.044 ms 1.2 ± 0.042 ms 0.998 ± 0.051
eval/Float64/evaluation_turbo 1.01 ± 0.065 ms 1.03 ± 0.064 ms 0.989 ± 0.088
eval/Float64/evaluation_turbo_bumper 1.2 ± 0.044 ms 1.19 ± 0.043 ms 1 ± 0.052
utils/combine_operators/break_sharing 0.0417 ± 0.0025 ms 0.0414 ± 0.0026 ms 1.01 ± 0.089
utils/convert/break_sharing 30 ± 4.4 μs 30.5 ± 5.2 μs 0.984 ± 0.22
utils/convert/preserve_sharing 0.102 ± 0.0074 ms 0.102 ± 0.0078 ms 1 ± 0.1
utils/copy/break_sharing 29.9 ± 4.5 μs 29.7 ± 5.2 μs 1.01 ± 0.23
utils/copy/preserve_sharing 0.102 ± 0.0079 ms 0.102 ± 0.0081 ms 0.997 ± 0.11
utils/count_constant_nodes/break_sharing 14 ± 2 μs 14.2 ± 1.9 μs 0.987 ± 0.19
utils/count_constant_nodes/preserve_sharing 0.0879 ± 0.0053 ms 0.0871 ± 0.0056 ms 1.01 ± 0.089
utils/count_depth/break_sharing 14.3 ± 2.2 μs 14.4 ± 2 μs 0.992 ± 0.21
utils/count_nodes/break_sharing 12.9 ± 1.6 μs 12.4 ± 1.7 μs 1.04 ± 0.2
utils/count_nodes/preserve_sharing 0.0872 ± 0.0052 ms 0.088 ± 0.0057 ms 0.991 ± 0.088
utils/get_set_constants!/break_sharing 0.034 ± 0.0029 ms 0.0344 ± 0.0035 ms 0.988 ± 0.13
utils/get_set_constants!/preserve_sharing 0.179 ± 0.009 ms 0.181 ± 0.01 ms 0.992 ± 0.076
utils/get_set_constants_parametric 0.0518 ± 0.0064 ms 0.0531 ± 0.0074 ms 0.976 ± 0.18
utils/has_constants/break_sharing 7.95 ± 1.1 μs 8.18 ± 0.96 μs 0.972 ± 0.18
utils/has_operators/break_sharing 2.52 ± 0.16 μs 2.52 ± 0.19 μs 1 ± 0.099
utils/hash/break_sharing 24.3 ± 2.4 μs 25.3 ± 3.5 μs 0.963 ± 0.17
utils/hash/preserve_sharing 0.101 ± 0.0064 ms 0.102 ± 0.007 ms 0.992 ± 0.093
utils/index_constant_nodes/break_sharing 30.8 ± 3.5 μs 30.5 ± 3.5 μs 1.01 ± 0.16
utils/index_constant_nodes/preserve_sharing 0.104 ± 0.0062 ms 0.104 ± 0.0076 ms 1 ± 0.095
utils/is_constant/break_sharing 8.43 ± 1 μs 8.41 ± 1.2 μs 1 ± 0.19
utils/simplify_tree/break_sharing 26.6 ± 2.7 μs 26.7 ± 3.7 μs 0.996 ± 0.17
utils/simplify_tree/preserve_sharing 0.108 ± 0.0064 ms 0.109 ± 0.0068 ms 0.992 ± 0.085
utils/string_tree/break_sharing 0.484 ± 0.023 ms 0.48 ± 0.024 ms 1.01 ± 0.07
utils/string_tree/preserve_sharing 0.582 ± 0.023 ms 0.582 ± 0.024 ms 1 ± 0.057
time_to_load 0.236 ± 0.0013 s 0.23 ± 0.0029 s 1.02 ± 0.014
Memory benchmarks
master ecb6117... master / ecb6117...
eval/ComplexF32/evaluation 0.975 k allocs: 2.5 MB 0.969 k allocs: 2.48 MB 1.01
eval/ComplexF64/evaluation 1.01 k allocs: 5.17 MB 1.01 k allocs: 5.15 MB 1
eval/Float32/derivative 4.71 k allocs: 17.7 MB 4.62 k allocs: 17.4 MB 1.02
eval/Float32/derivative_turbo 4.65 k allocs: 17.5 MB 4.62 k allocs: 17.4 MB 1.01
eval/Float32/evaluation 0.975 k allocs: 1.27 MB 0.963 k allocs: 1.25 MB 1.01
eval/Float32/evaluation_bumper 0.303 k allocs: 0.393 MB 0.303 k allocs: 0.393 MB 1
eval/Float32/evaluation_turbo 0.963 k allocs: 1.25 MB 0.951 k allocs: 1.24 MB 1.01
eval/Float32/evaluation_turbo_bumper 0.303 k allocs: 0.393 MB 0.303 k allocs: 0.393 MB 1
eval/Float64/derivative 4.73 k allocs: 0.0346 GB 4.83 k allocs: 0.0353 GB 0.978
eval/Float64/derivative_turbo 4.8 k allocs: 0.0351 GB 4.77 k allocs: 0.0349 GB 1.01
eval/Float64/evaluation 0.999 k allocs: 2.56 MB 0.999 k allocs: 2.56 MB 1
eval/Float64/evaluation_bumper 0.303 k allocs: 0.771 MB 0.303 k allocs: 0.771 MB 1
eval/Float64/evaluation_turbo 0.975 k allocs: 2.5 MB 1.01 k allocs: 2.58 MB 0.967
eval/Float64/evaluation_turbo_bumper 0.303 k allocs: 0.771 MB 0.303 k allocs: 0.771 MB 1
utils/combine_operators/break_sharing 4 allocs: 0.953 kB 4 allocs: 0.953 kB 1
utils/convert/break_sharing 2 k allocs: 0.123 MB 2 k allocs: 0.123 MB 1
utils/convert/preserve_sharing 2.4 k allocs: 0.192 MB 2.4 k allocs: 0.192 MB 1
utils/copy/break_sharing 2 k allocs: 0.123 MB 2 k allocs: 0.123 MB 1
utils/copy/preserve_sharing 2.4 k allocs: 0.192 MB 2.4 k allocs: 0.192 MB 1
utils/count_constant_nodes/break_sharing 4 allocs: 0.953 kB 4 allocs: 0.953 kB 1
utils/count_constant_nodes/preserve_sharing 0.404 k allocs: 0.0696 MB 0.404 k allocs: 0.0696 MB 1
utils/count_depth/break_sharing 4 allocs: 0.953 kB 4 allocs: 0.953 kB 1
utils/count_nodes/break_sharing 4 allocs: 0.953 kB 4 allocs: 0.953 kB 1
utils/count_nodes/preserve_sharing 0.404 k allocs: 0.0696 MB 0.404 k allocs: 0.0696 MB 1
utils/get_set_constants!/break_sharing 0.898 k allocs: 25.2 kB 0.898 k allocs: 25.2 kB 1
utils/get_set_constants!/preserve_sharing 1.7 k allocs: 0.138 MB 1.7 k allocs: 0.138 MB 1
utils/get_set_constants_parametric 1.42 k allocs: 0.0663 MB 1.42 k allocs: 0.0663 MB 1
utils/has_constants/break_sharing 4 allocs: 0.203 kB 4 allocs: 0.203 kB 1
utils/has_operators/break_sharing 4 allocs: 0.203 kB 4 allocs: 0.203 kB 1
utils/hash/break_sharing 0.104 k allocs: 2.52 kB 0.104 k allocs: 2.52 kB 1
utils/hash/preserve_sharing 0.504 k allocs: 0.0711 MB 0.504 k allocs: 0.0711 MB 1
utils/index_constant_nodes/break_sharing 2.1 k allocs: 0.094 MB 2.1 k allocs: 0.094 MB 1
utils/index_constant_nodes/preserve_sharing 2.5 k allocs: 0.163 MB 2.5 k allocs: 0.163 MB 1
utils/is_constant/break_sharing 4 allocs: 0.203 kB 4 allocs: 0.203 kB 1
utils/simplify_tree/break_sharing 4 allocs: 0.953 kB 4 allocs: 0.953 kB 1
utils/simplify_tree/preserve_sharing 0.404 k allocs: 0.0696 MB 0.404 k allocs: 0.0696 MB 1
utils/string_tree/break_sharing 11.8 k allocs: 1.04 MB 11.8 k allocs: 1.04 MB 1
utils/string_tree/preserve_sharing 12.2 k allocs: 1.11 MB 12.2 k allocs: 1.11 MB 1
time_to_load 0.159 k allocs: 11.2 kB 0.159 k allocs: 11.2 kB 1

@SymbolicML SymbolicML deleted a comment from github-actions bot May 26, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 15258008479

Details

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 95.586%

Totals Coverage Status
Change from base Build 15258002007: 0.007%
Covered Lines: 2577
Relevant Lines: 2696

💛 - Coveralls

Copy link

codecov bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.64%. Comparing base (b705e46) to head (ecb6117).
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #128   +/-   ##
=======================================
  Coverage   96.63%   96.64%           
=======================================
  Files          30       30           
  Lines        2589     2593    +4     
=======================================
+ Hits         2502     2506    +4     
  Misses         87       87           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MilesCranmer MilesCranmer merged commit b114eb0 into master Jun 26, 2025
14 checks passed
@MilesCranmer MilesCranmer deleted the skip-fused-kernels branch June 26, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants