Revert "refactor(angular-query): migrate from tsup to vite (#9281)" (#9282)

This reverts commit 1c7c276.

Author: arnoud-dv

packages/angular-query-experimental/.attw.json

@@ -1,3 +1,3 @@
 {
-  "ignoreRules": ["cjs-resolves-to-esm"]
+  "ignoreRules": ["cjs-resolves-to-esm", "no-resolution"]
 }

packages/angular-query-experimental/package.json

@@ -27,7 +27,7 @@
     "tanstack"
   ],
   "scripts": {
-    "clean": "premove ./build ./coverage ./dist-ts ./**.d.ts",
+    "clean": "premove ./build ./coverage ./dist-ts",
     "compile": "tsc --build",
     "test:eslint": "eslint ./src",
     "test:types": "npm-run-all --serial test:types:*",
@@ -42,29 +42,28 @@
     "test:types:tscurrent": "tsc --build",
     "test:lib": "vitest",
     "test:lib:dev": "pnpm run test:lib --watch",
-    "test:build": "pnpm pack && publint *.tgz --strict && attw *.tgz; premove *.tgz",
-    "build": "vite build",
-    "prepack": "node scripts/prepack.js",
-    "postpack": "node scripts/postpack.js"
+    "test:build": "publint --strict && attw --pack",
+    "build": "pnpm build:tsup",
+    "build:tsup": "tsup --tsconfig tsconfig.prod.json"
   },
   "type": "module",
-  "types": "dist/types/index.d.ts",
-  "module": "dist/index.mjs",
+  "types": "build/index.d.ts",
+  "module": "build/index.mjs",
   "exports": {
     ".": {
-      "types": "./dist/types/index.d.ts",
       "@tanstack/custom-condition": "./src/index.ts",
-      "default": "./dist/index.mjs"
+      "types": "./build/index.d.ts",
+      "default": "./build/index.mjs"
     },
     "./package.json": {
       "default": "./package.json"
     }
   },
   "sideEffects": false,
   "files": [
-    "**/*.d.ts",
-    "dist",
-    "!dist/types/**"
+    "build",
+    "src",
+    "!src/__tests__"
   ],
   "dependencies": {
     "@tanstack/query-core": "workspace:*",
@@ -78,25 +77,10 @@
     "@angular/platform-browser-dynamic": "^20.0.0",
     "@tanstack/query-test-utils": "workspace:*",
     "eslint-plugin-jsdoc": "^50.5.0",
-    "npm-run-all2": "^5.0.0",
-    "vite-plugin-dts": "4.2.3",
-    "vite-plugin-externalize-deps": "^0.9.0",
-    "vite-tsconfig-paths": "^5.1.4"
+    "npm-run-all2": "^5.0.0"
   },
   "peerDependencies": {
     "@angular/common": ">=16.0.0",
     "@angular/core": ">=16.0.0"
-  },
-  "publishConfig": {
-    "types": "index.d.ts",
-    "exports": {
-      ".": {
-        "types": "./index.d.ts",
-        "default": "./dist/index.mjs"
-      },
-      "./package.json": {
-        "default": "./package.json"
-      }
-    }
   }
 }

packages/angular-query-experimental/scripts/postpack.js

@@ -3,6 +3,8 @@
   "compilerOptions": {
     "outDir": "./dist-ts",
     "rootDir": ".",
+    "noImplicitOverride": true,
+    "noPropertyAccessFromIndexSignature": true,
     "noFallthroughCasesInSwitch": true,
     "useDefineForClassFields": false,
     "target": "ES2022"

packages/angular-query-experimental/scripts/prepack.js

@@ -3,7 +3,6 @@
   "compilerOptions": {
     "incremental": false,
     "composite": false,
-    "rootDir": "../../",
-    "customConditions": null
+    "rootDir": "../../"
   }
 }

packages/angular-query-experimental/tsconfig.json

@@ -0,0 +1,13 @@
+import { defineConfig } from 'tsup'
+
+export default defineConfig({
+  entry: ['src/index.ts'],
+  sourcemap: true,
+  clean: true,
+  format: ['esm'],
+  dts: true,
+  outDir: 'build',
+  outExtension({ format }) {
+    return format === 'esm' ? { js: '.mjs' } : { js: '.js' }
+  },
+})

packages/angular-query-experimental/tsconfig.prod.json

@@ -1,32 +1,8 @@
-import { defineConfig, mergeConfig } from 'vitest/config'
-import { externalizeDeps } from 'vite-plugin-externalize-deps'
-import tsconfigPaths from 'vite-tsconfig-paths'
-import dts from 'vite-plugin-dts'
-import packageJson from './package.json'
-import type { Options } from '@tanstack/config/vite'
-
-function ensureImportFileExtension({
-  content,
-  extension,
-}: {
-  content: string
-  extension: string
-}) {
-  // replace e.g. `import { foo } from './foo'` with `import { foo } from './foo.js'`
-  content = content.replace(
-    /(im|ex)port\s[\w{}/*\s,]+from\s['"](?:\.\.?\/)+?[^.'"]+(?=['"];?)/gm,
-    `$&.${extension}`,
-  )
+import { defineConfig } from 'vitest/config'
 
-  // replace e.g. `import('./foo')` with `import('./foo.js')`
-  content = content.replace(
-    /import\(['"](?:\.\.?\/)+?[^.'"]+(?=['"];?)/gm,
-    `$&.${extension}`,
-  )
-  return content
-}
+import packageJson from './package.json'
 
-const config = defineConfig({
+export default defineConfig({
   // fix from https://github.com/vitest-dev/vitest/issues/6992#issuecomment-2509408660
   resolve: {
     conditions: ['@tanstack/custom-condition'],
@@ -50,73 +26,3 @@ const config = defineConfig({
     restoreMocks: true,
   },
 })
-
-// copy from @tanstack/config/vite with changes:
-// - dts outDir: dist/types
-// - build - lib - fileName: [name.mjs]
-// - rollup - output - preserveModulesRoot: src
-export const tanstackViteConfig = (options: Options) => {
-  const outDir = options.outDir ?? 'dist'
-  const cjs = options.cjs ?? true
-
-  return defineConfig({
-    plugins: [
-      externalizeDeps({ include: options.externalDeps ?? [] }),
-      tsconfigPaths({
-        projects: options.tsconfigPath ? [options.tsconfigPath] : undefined,
-      }),
-      dts({
-        outDir: `dist/types`,
-        entryRoot: options.srcDir,
-        include: options.srcDir,
-        exclude: options.exclude,
-        tsconfigPath: options.tsconfigPath,
-        compilerOptions: {
-          module: 99, // ESNext
-          declarationMap: false,
-        },
-        beforeWriteFile: (filePath, content) => {
-          // content =
-          //   options.beforeWriteDeclarationFile?.(filePath, content) || content
-          return {
-            filePath,
-            content: ensureImportFileExtension({ content, extension: 'js' }),
-          }
-        },
-        afterDiagnostic: (diagnostics) => {
-          if (diagnostics.length > 0) {
-            console.error('Please fix the above type errors')
-            process.exit(1)
-          }
-        },
-      }),
-    ],
-    build: {
-      outDir,
-      minify: false,
-      sourcemap: true,
-      lib: {
-        entry: options.entry,
-        formats: cjs ? ['es', 'cjs'] : ['es'],
-        fileName: () => '[name].mjs',
-      },
-      rollupOptions: {
-        output: {
-          preserveModules: true,
-          preserveModulesRoot: 'src',
-        },
-      },
-    },
-  })
-}
-
-export default mergeConfig(
-  config,
-  tanstackViteConfig({
-    cjs: false,
-    entry: ['./src/index.ts'],
-    exclude: ['src/__tests__'],
-    srcDir: './src',
-    tsconfigPath: 'tsconfig.prod.json',
-  }),
-)

packages/angular-query-experimental/tsup.config.js

@@ -1,3 +1,3 @@
 {
-  "ignoreRules": ["cjs-resolves-to-esm"]
+  "ignoreRules": ["cjs-resolves-to-esm", "no-resolution"]
 }