refactor(angular-query): migrate from tsup to vite #9281

arnoud-dv · 2025-06-17T13:08:43Z

Allows for more flexibility in build process.

Adds prepack and postpack scripts to publish type declaration files in package root, a prerequisite to support subpath exports while also supporting applications using "moduleResolution": "node".

Fixes moduleResolution: node16

…-build-vite

nx-cloud · 2025-06-17T13:09:14Z

View your CI Pipeline Execution ↗ for commit e6a1444.

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	1m 23s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	10s	View ↗

☁️ Nx Cloud last updated this comment at 2025-06-17 17:58:49 UTC

pkg-pr-new · 2025-06-17T13:12:06Z

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9281

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9281

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9281

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9281

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9281

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9281

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9281

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9281

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9281

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9281

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9281

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9281

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9281

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9281

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9281

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9281

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9281

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9281

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9281

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9281

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9281

commit: e6a1444

codecov · 2025-06-17T15:49:33Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.37%. Comparing base (bd3ac49) to head (e6a1444).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #9281   +/-   ##
=======================================
  Coverage   45.37%   45.37%           
=======================================
  Files         207      207           
  Lines        8276     8276           
  Branches     1864     1865    +1     
=======================================
  Hits         3755     3755           
  Misses       4080     4080           
  Partials      441      441

Components	Coverage Δ
@tanstack/angular-query-devtools-experimental	`∅ <ø> (∅)`
@tanstack/angular-query-experimental	`85.00% <ø> (ø)`
@tanstack/eslint-plugin-query	`83.24% <ø> (ø)`
@tanstack/query-async-storage-persister	`43.85% <ø> (ø)`
@tanstack/query-broadcast-client-experimental	`24.39% <ø> (ø)`
@tanstack/query-codemods	`0.00% <ø> (ø)`
@tanstack/query-core	`98.15% <ø> (ø)`
@tanstack/query-devtools	`3.55% <ø> (ø)`
@tanstack/query-persist-client-core	`79.47% <ø> (ø)`
@tanstack/query-sync-storage-persister	`84.61% <ø> (ø)`
@tanstack/query-test-utils	`77.77% <ø> (ø)`
@tanstack/react-query	`95.93% <ø> (ø)`
@tanstack/react-query-devtools	`10.00% <ø> (ø)`
@tanstack/react-query-next-experimental	`∅ <ø> (∅)`
@tanstack/react-query-persist-client	`100.00% <ø> (ø)`
@tanstack/solid-query	`78.13% <ø> (ø)`
@tanstack/solid-query-devtools	`∅ <ø> (∅)`
@tanstack/solid-query-persist-client	`100.00% <ø> (ø)`
@tanstack/svelte-query	`88.07% <ø> (ø)`
@tanstack/svelte-query-devtools	`∅ <ø> (∅)`
@tanstack/svelte-query-persist-client	`100.00% <ø> (ø)`
@tanstack/vue-query	`71.10% <ø> (ø)`
@tanstack/vue-query-devtools	`∅ <ø> (∅)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

hakimio · 2025-06-17T19:50:35Z

@arnoud-dv the production bundle seems to have incorrect types config.

arnoud-dv · 2025-06-17T21:04:06Z

@hakimio do you mean it should be

"types": "./index.d.ts"

hakimio · 2025-06-17T21:06:36Z

@arnoud-dv no, I mean that index.d.ts no longer exists in the root dir - it was moved to dist/types, but the production bundle package.json was not updated correctly (like shown in the screenshot above).

arnoud-dv · 2025-06-17T21:11:41Z

There's a prepack lifecycle script that makes sure the type declarations are linked from the package root at the moment the package is published. I want to add sub path exports and to support the still widely used "moduleResolution": "node", type declarations files should follow the same path structure.

hakimio · 2025-06-17T21:17:52Z

Ok, let's do it step-by-step:

download the latest @tanstack/angular-query-experimental package from npm:

npm pack @tanstack/angular-query-experimental

Open the archive and inspect its contents.
Does it have index.d.ts in the root dir? No.
Now open package.json and check what it says:

"exports": {
    ".": {
      "types": "./index.d.ts",
      "default": "./dist/index.mjs"
    }
  }

It points to non-existant index.d.ts file.

This reverts commit 1c7c276.

arnoud-dv · 2025-06-17T21:35:06Z

I see - I'll revert it for now.

Tested this very well, preview package from the PR build was working perfectly on all supported Angular versions and when looking at its files contents it was also good. But probably the actual publish script behaviour is different. I'll look at this later.

Thanks for reporting the issue!

…9282) This reverts commit 1c7c276.

arnoud-dv added 2 commits June 17, 2025 15:01

chore(angular-query): migrate from tsup to vite

ca2fc73

Merge remote-tracking branch 'upstream/main' into chore/angular-query…

1aeea49

…-build-vite

github-actions bot added the package: angular-query-experimental label Jun 17, 2025

arnoud-dv changed the title ~~chore(angular-query): migrate from tsup to vite~~ refactor(angular-query): migrate from tsup to vite Jun 17, 2025

build fixes

e6a1444

arnoud-dv force-pushed the chore/angular-query-build-vite branch from 862240b to e6a1444 Compare June 17, 2025 17:56

arnoud-dv merged commit 1c7c276 into TanStack:main Jun 17, 2025
7 checks passed

arnoud-dv deleted the chore/angular-query-build-vite branch June 17, 2025 18:03

arnoud-dv added a commit that referenced this pull request Jun 17, 2025

Revert "refactor(angular-query): migrate from tsup to vite (#9281)"

7410c95

This reverts commit 1c7c276.

arnoud-dv added a commit that referenced this pull request Jun 17, 2025

Revert "refactor(angular-query): migrate from tsup to vite (#9281)" (#…

c251358

…9282) This reverts commit 1c7c276.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

refactor(angular-query): migrate from tsup to vite #9281

refactor(angular-query): migrate from tsup to vite #9281

Uh oh!

arnoud-dv commented Jun 17, 2025 •

edited

Loading

Uh oh!

nx-cloud bot commented Jun 17, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Jun 17, 2025 •

edited

Loading

Uh oh!

codecov bot commented Jun 17, 2025 •

edited

Loading

Uh oh!

Uh oh!

hakimio commented Jun 17, 2025

Uh oh!

arnoud-dv commented Jun 17, 2025

Uh oh!

hakimio commented Jun 17, 2025 •

edited

Loading

Uh oh!

arnoud-dv commented Jun 17, 2025

Uh oh!

hakimio commented Jun 17, 2025

Uh oh!

arnoud-dv commented Jun 17, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

refactor(angular-query): migrate from tsup to vite #9281

refactor(angular-query): migrate from tsup to vite #9281

Uh oh!

Conversation

arnoud-dv commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nx-cloud bot commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

hakimio commented Jun 17, 2025

Uh oh!

arnoud-dv commented Jun 17, 2025

Uh oh!

hakimio commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arnoud-dv commented Jun 17, 2025

Uh oh!

hakimio commented Jun 17, 2025

Uh oh!

arnoud-dv commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

arnoud-dv commented Jun 17, 2025 •

edited

Loading

nx-cloud bot commented Jun 17, 2025 •

edited

Loading

pkg-pr-new bot commented Jun 17, 2025 •

edited

Loading

codecov bot commented Jun 17, 2025 •

edited

Loading

hakimio commented Jun 17, 2025 •

edited

Loading

arnoud-dv commented Jun 17, 2025 •

edited

Loading