Skip to content

perf: improve performance of util function "difference" in quriesObserver.ts in query-core package #9201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 3, 2025
Merged

perf: improve performance of util function "difference" in quriesObserver.ts in query-core package #9201

merged 2 commits into from
Jun 3, 2025

Conversation

novice0840
Copy link
Contributor

I changed the internal behavior of the "difference" function in quriesObserver.ts from includes function to using has function in sets

And this is faster when the arrays are longer. I included a link to the code sandbox below so you can see the specific performance differences.

Codesandbox Link

https://codesandbox.io/p/devbox/crazy-cherry-627tsr

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 28, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 0666f2b.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 4m 13s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 47s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-03 11:06:04 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented May 28, 2025 •
edited
Loading

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9201

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9201

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9201

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9201

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9201

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9201

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9201

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9201

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9201

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9201

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9201

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9201

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9201

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9201

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9201

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9201

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9201

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9201

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9201

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9201

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9201

commit: 0666f2b

@codecov Codecov
Copy link

codecov bot commented May 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.64%. Comparing base (b2af568) to head (0666f2b).
Report is 21 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #9201       +/-   ##
===========================================
+ Coverage   45.19%   59.64%   +14.45%     
===========================================
  Files         206      136       -70     
  Lines        8240     5509     -2731     
  Branches     1861     1472      -389     
===========================================
- Hits         3724     3286      -438     
+ Misses       4076     1925     -2151     
+ Partials      440      298      -142
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 85.00% <ø> (-0.05%) ⬇️
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental 24.39% <ø> (ø)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core 98.15% <100.00%> (+0.02%) ⬆️
@tanstack/query-devtools 3.55% <ø> (-0.01%) ⬇️
@tanstack/query-persist-client-core 78.32% <ø> (ø)
@tanstack/query-sync-storage-persister 84.61% <ø> (ø)
@tanstack/query-test-utils ∅ <ø> (∅)
@tanstack/react-query 96.02% <ø> (+0.02%) ⬆️
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.13% <ø> (-0.08%) ⬇️
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 88.07% <ø> (-0.08%) ⬇️
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 70.85% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@novice0840 novice0840 changed the title perf: change "difference" util function perf: improve performance of util function "difference" in quriesObserver.ts in query-core package May 28, 2025
TkDodo
TkDodo reviewed Jun 2, 2025
View reviewed changes
@TkDodo TkDodo merged commit 57c6ce1 into TanStack:main Jun 3, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TkDodo TkDodo TkDodo approved these changes

Assignees
No one assigned
Labels
package: query-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@novice0840 @TkDodo