docs(readme): fix broken Speakeasy image by replacing removed _build path with public asset #9248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced sponsor image paths that pointed to `_build/assets/...` (invalid in GitHub markdown context) - Updated to use public URLs (`https://tanstack.com/assets/...`) to prevent broken images
developerjhp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Speakeasy sponsor image in the README was previously using a
_build/assets/...path.This file seems to have been removed or moved, causing the image to break on GitHub.
While the path may have been valid before,
_build/is generally reserved for internal static site builds (e.g. tanstack.com), and is not guaranteed to be stable or public.Solution
Replaced the
_buildpath with a stable public URL underhttps://tanstack.com/assets/, which ensures consistent rendering on GitHub, npm, and other markdown consumers.Result