Wrong valueTypes.is type

[xepozz]

I've tried to customise value with usage valueTypes.is, but it shows that I'm wrong.

I think we need to change types declaration as the following.

declare type DataType<ValueType = unknown> = {
-    is: (value: any) => value is ValueType;
+    is: (value: ValueType) => boolean;
    Component: React.ComponentType<DataItemProps<ValueType>>;
    Editor?: React.ComponentType<EditorProps<ValueType>>;
    PreComponent?: React.ComponentType<DataItemProps<ValueType>>;
    PostComponent?: React.ComponentType<DataItemProps<ValueType>>;
};

What do you think?

And here is my workaround:

is: ((value: unknown): any => typeof value === 'string' && value.startsWith('@')) as any,

[himself65]

The reason is is valueType is a stronger type here

for example

I'm creating a helper function that could help this

[himself65]

I created a helper function that you won't worry about the type

[xepozz]

I created a helper function that you won't worry about the type

Actually, the best way is to leave is: (value: ValueType) => boolean. There is no need to have value is ValueType as a return type. Semantically it's always true. Isn't it?

[xepozz]

@himself65 up

[himself65]

You might be right. I'm not sure how people really deal with this API

[xepozz]

Logically is is just a boolean getter. I don't see any reasons to restrict the return type as value is T