feat: support displayObjectSize
#102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for any-viewer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov ReportBase: 89.78% // Head: 89.90% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
==========================================
+ Coverage 89.78% 89.90% +0.12%
==========================================
Files 18 18
Lines 1821 1843 +22
Branches 257 262 +5
==========================================
+ Hits 1635 1657 +22
Misses 186 186
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
himself65
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #101
There is a tiny problem in two places:
https://github.com/Yazawazi/json-viewer/blob/main/src/components/DataTypes/Object.tsx#L53-L66
https://github.com/Yazawazi/json-viewer/blob/main/src/components/DataTypes/Object.tsx#L95-L110
The
pl(padding-left) property causes the gap to be increased on the left side. My description may not be clear, so here are the pictures:displayObjectSize:truedisplayObjectSize:false