Skip to content

remove @textea/dev-kit from dependencies #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 6, 2023
Merged

Conversation

forrestbao
Copy link
Member

Arguments here #133 (comment)
Issue #133

@netlify
Copy link

netlify bot commented Jan 5, 2023

Deploy Preview for any-viewer failed.

Name Link
🔨 Latest commit 02f140d
🔍 Latest deploy log https://app.netlify.com/sites/any-viewer/deploys/63b740c507df2e000909d6bc

@forrestbao forrestbao changed the title remove @textea/dev-kit from dependencies [WIP] remove @textea/dev-kit from dependencies Jan 5, 2023
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Base: 87.91% // Head: 87.90% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (02f140d) compared to base (9c2dee6).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
- Coverage   87.91%   87.90%   -0.01%     
==========================================
  Files          18       18              
  Lines        1903     1902       -1     
  Branches      338      338              
==========================================
- Hits         1673     1672       -1     
  Misses        230      230              
Impacted Files Coverage Δ
src/stores/typeRegistry.tsx 94.72% <0.00%> (-0.02%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@forrestbao forrestbao merged commit 8313a04 into TexteaInc:main Jan 6, 2023
@asafshen
Copy link

@forrestbao thanks for the quick fix! any estimation for when a new version of this package will be publish?

@forrestbao
Copy link
Member Author

@asafshen we will bump the version soon. Thank you for your patience.

@pionxzh
Copy link
Collaborator

pionxzh commented Jan 11, 2023

@asafshen v2.12.5 has been released. 🚀

@asafshen
Copy link

@forrestbao @pionxzh thanks for the quick release! much appreciated

@forrestbao forrestbao changed the title [WIP] remove @textea/dev-kit from dependencies remove @textea/dev-kit from dependencies Jan 11, 2023
Yazawazi pushed a commit that referenced this pull request Mar 10, 2023
* remove @textea/dev-kit from dependencies
* add dependencies extended from @textea/dev-kit
* regenerate yarn.lock after changing dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants