Skip to content

Move toolkit to scalalang org #1930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 28, 2023

Conversation

szymon-rd
Copy link
Contributor

@szymon-rd szymon-rd commented Mar 16, 2023

@lwronski please take a look
To be coordinated with scala/toolkit#10

@bishabosha
Copy link
Contributor

bishabosha commented Mar 27, 2023

there are a couple of mentions of 0.1.4 explicitly in the tests, and that fails because that version is not published under org.scala-lang organisation

@szymon-rd szymon-rd force-pushed the move-toolkit-to-scalalang branch from 1d8ba21 to dbd43b2 Compare March 28, 2023 13:32
@bishabosha
Copy link
Contributor

bishabosha commented Mar 28, 2023

it seems that https://github.com/VirtusLab/scala-cli/blob/main/website/docs/release_notes.md has an explicit code fence that is being compiled and failing the docs-tests:

```scala compile
//> using toolkit "0.1.4"
```

should there be conditional processing of the organisation based on the version for backwards compatibility ? otherwise I guess we can stop compiling this snippet

Copy link
Contributor

@lwronski lwronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szymon-rd Thanks! LGTM

@lwronski lwronski merged commit 4a53295 into VirtusLab:main Mar 28, 2023
@Gedochao Gedochao added the internal Internal or build-related changes label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal or build-related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants