Principal Types: Add signature interop #7777
Merged
+69
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
reviewed
Aug 4, 2025
src/ir/principal-type.h
Outdated
Comment on lines
133
to
134
| // Flip the params and results. | ||
| void flip() { |
There was a problem hiding this comment.
In general there's no guarantee that this produces a valid principal type because the order in which variables must be introduced in the parameters does not necessarily match the order in which they're used in the results. What will this be used for?
There was a problem hiding this comment.
Oh, right, I was just using this to tinker with some stuff that happens to not have variables (the tinkering failed and I don't need it). I'll remove this part then.
tlively
approved these changes
Aug 4, 2025
|
It might be worth adding some quick unit tests, but not critical. |
|
Tests added. |
tlively
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.