[spec] Fix block values #609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binji
reviewed
Nov 29, 2017
| @@ -964,24 +964,22 @@ Exiting :math:`\instr^\ast` with label :math:`L` | |||
|
|
|||
| When the end of a block is reached without a jump or trap aborting it, then the following steps are performed. | |||
|
|
|||
| 1. Let :math:`n` be the arity of :math:`L`. | |||
| 1. Let :math:`m` be the number of values on the top of the stack. | |||
There was a problem hiding this comment.
I know what you mean by "values on top of the stack", but is that mentioned anywhere in the spec?
There was a problem hiding this comment.
The runtime section defines the stack. Although never defined explicitly, the spec mentions "the top of the stack" in various places. Do you think it might be too unclear?
There was a problem hiding this comment.
I think it's probably fine when it's just a few values. This case is perhaps a little less clear since you're only counting up from the label. That said, the formula below makes it explicit.
binji
approved these changes
Nov 29, 2017
rossberg
added a commit
that referenced
this pull request
Nov 30, 2017
generated from commit 5130369
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #608.