Handle ELF binary with no program segments #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffontaine
changed the title
ffontaine
force-pushed
the
master
branch
2 times, most recently
from
a603c84 to
4b042e4
Compare
|
|
|
Hi @ffontaine and thanks for this PR. Could you provide a test binary and make a PR into https://github.com/Wenzel/checksec.py-test-binaries ? |
|
Hi, PR created: Wenzel/checksec.py-test-binaries#2 |
|
@ffontaine just merged your test binary |
|
Done |
|
Thanks ! |
|
I sent a new PR as pytest does not handle link on |
Do not return False for NX and No for RELRO when there is no program segments in the ELF binary file (e.g. kernel module). This is inspired from slimm609/checksec@29aea68 For RELRO, a new NA value is added For NX, True is returned to avoid changing NX type from boolean to string Signed-off-by: Fabrice Fontaine <[email protected]>
|
CI is finally green :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not return
Falsefor NX andNofor RELRO when there is no program segments in the ELF binary file (e.g. kernel module).This is inspired from slimm609/checksec@29aea68
For RELRO, a new
NAvalue is addedFor NX,
Trueis returned to avoid changing NX type from boolean to string