Skip to content

feat: 添加minicpm3模型缺失的算子 #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

onenewcode
Copy link
Contributor

No description provided.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clippy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@YdrMaster YdrMaster marked this pull request as draft February 14, 2025 12:19
@onenewcode onenewcode force-pushed the dev branch 5 times, most recently from ec21c79 to 7fa85f7 Compare February 18, 2025 03:25
@onenewcode onenewcode force-pushed the dev branch 4 times, most recently from e754707 to ab65dfa Compare February 20, 2025 07:46
pub dr: MaybeDyn<usize>,
}

impl<H: Hardware> Args<H> {

Check warning

Code scanning / clippy

associated function new_null is never used Warning

associated function new\_null is never used

impl<H: Hardware> Args<H> {
#[allow(clippy::too_many_arguments)]
pub(crate) fn new_null(

Check warning

Code scanning / clippy

associated function new_null is never used Warning

associated function new\_null is never used
use ndarray_layout::ArrayLayout;
use std::marker::PhantomData;

pub struct Operator<Hardware, MatMul, Softmax, Rearrange> {

Check warning

Code scanning / clippy

field rearrange is never read Warning

field rearrange is never read
pub struct Operator<Hardware, MatMul, Softmax, Rearrange> {
mat_mul: MatMul,
softmax: Softmax,
rearrange: Rearrange,

Check warning

Code scanning / clippy

field rearrange is never read Warning

field rearrange is never read

fn scheme(
&mut self,
args: &Self::Args,

Check warning

Code scanning / clippy

unused variable: args Warning

unused variable: args
fn scheme(
&mut self,
args: &Self::Args,
max_workspace_size: usize,

Check warning

Code scanning / clippy

unused variable: max_workspace_size Warning

unused variable: max\_workspace\_size

fn scheme(
&mut self,
args: &Self::Args,

Check warning

Code scanning / clippy

unused variable: args Warning

unused variable: args
fn scheme(
&mut self,
args: &Self::Args,
max_workspace_size: usize,

Check warning

Code scanning / clippy

unused variable: max_workspace_size Warning

unused variable: max\_workspace\_size
dt,
nh,
seq,
att,

Check warning

Code scanning / clippy

unused variable: att Warning

unused variable: att
seq,
att,
dkv,
dv,

Check warning

Code scanning / clippy

unused variable: dv Warning

unused variable: dv
mask,
pos,
} = args;
let &[nh_skv, att_skv, dkv_skv] = kv_layout.strides() else {

Check warning

Code scanning / clippy

unused variable: nh_skv Warning

unused variable: nh\_skv
let &[nh_skv, att_skv, dkv_skv] = kv_layout.strides() else {
unreachable!()
};
let &[nh_skr, att_skr, dr_skr] = kr_layout.strides() else {

Check warning

Code scanning / clippy

unused variable: dr_skr Warning

unused variable: dr\_skr
let &[nh_skr, att_skr, dr_skr] = kr_layout.strides() else {
unreachable!()
};
let &[nh_sa, dv_sa, dkv_sa] = absorb_layout.strides() else {

Check warning

Code scanning / clippy

unused variable: nh_sa Warning

unused variable: nh\_sa
let &[nh_skr, att_skr, dr_skr] = kr_layout.strides() else {
unreachable!()
};
let &[nh_sa, dv_sa, dkv_sa] = absorb_layout.strides() else {

Check warning

Code scanning / clippy

unused variable: dv_sa Warning

unused variable: dv\_sa
let &[nh_skr, att_skr, dr_skr] = kr_layout.strides() else {
unreachable!()
};
let &[nh_sa, dv_sa, dkv_sa] = absorb_layout.strides() else {

Check warning

Code scanning / clippy

unused variable: dkv_sa Warning

unused variable: dkv\_sa
let &[nh_skrc, buf_skrc, dh_skrc] = kr_cache_layout.strides() else {
unreachable!()
};
let ele = dt.nbytes();

Check warning

Code scanning / clippy

unused variable: ele Warning

unused variable: ele
short,
origin_pos,
..
} => unsafe {

Check warning

Code scanning / clippy

unnecessary unsafe block Warning

unnecessary unsafe block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant